Closed Bug 1344693 Opened 7 years ago Closed 7 years ago

Popup notification from Add-ons Manager has "undefined" origin.

Categories

(Toolkit :: Add-ons Manager, defect)

51 Branch
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1341011

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

separated from bug 1344674.

Steps to Reproduce:
  1. Follow this example
       https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Your_first_WebExtension
  2. package it with "web-ext build"
  3. try to install it to Firefox developers edition with xpinstall.signatures.required==false

Actual result:
  Door hanger says
    undefined - this add-on couldn't be installed because it appears to be corrupt.

Expected result:
  "undefined" isn't there
changed to avoid setting undefined to attribute.
Attachment #8843937 - Flags: review?(aswan)
See Also: → 1344674
Comment on attachment 8843937 [details] [diff] [review]
Do not set origin attribute of popup notification if it is undefined.

This is sweeping the real problem (the fact that we're not passing in a real nsIURI here) under the rug.
Attachment #8843937 - Flags: review?(aswan) → review-
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: