Closed Bug 1344701 Opened 7 years ago Closed 7 years ago

latest nightly makes tampermonkey addon unusable

Categories

(Firefox :: Extension Compatibility, defect)

54 Branch
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- unaffected
firefox54 --- wontfix
firefox55 --- wontfix

People

(Reporter: ale82ale, Unassigned)

References

Details

(Keywords: regression)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170303030202

Steps to reproduce:

since saturday nighlty v 54 on osx i cannot use tampermonkey anymore,clicking on tampermonkey icon in toolbar all i get is an empty popup and userscript are not working
Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0598ed8d643b46e20172348ac597cd5629661aac&tochange=83e85e21d35404878a2e4bb9b26f66e8b817c99b

83e85e21d354	Kris Maglione — Bug 1258360: Implement onMessageExternal and onConnectExternal. r=mixedpuppy
Blocks: 1258360
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → Extension Compatibility
Ever confirmed: true
Keywords: regression
OS: Unspecified → All
Hardware: Unspecified → All
Summary: latest nighlty on osx causes problem to tampermonkey → latest nighlty causes problem to tampermonkey
Kris, can you investigate?
Flags: needinfo?(kmaglione+bmo)
Summary: latest nighlty causes problem to tampermonkey → latest nightly makes tampermonkey addon unusable
I guess the extension is expecting `runtime.id` to be the same as the host in extension URLs, which is no longer the case. It needs to use runtime.getURL() instead.
Flags: needinfo?(kmaglione+bmo)
(In reply to Kris Maglione [:kmag] from comment #3)
> I guess the extension is expecting `runtime.id` to be the same as the host
> in extension URLs, which is no longer the case. It needs to use
> runtime.getURL() instead.

OK, thanks.  So this is a known addon breakage?  Is there going to be documentation on this somewhere (release notes?)?
Flags: needinfo?(kmaglione+bmo)
It's not known breakage, no, but it is what's causing the issue with this add-on. I added the addon-compat keyword to bug 1258360.
Flags: needinfo?(kmaglione+bmo)
(In reply to Kris Maglione [:kmag] from comment #5)
> It's not known breakage, no, but it is what's causing the issue with this
> add-on. I added the addon-compat keyword to bug 1258360.

Thanks.

Sorry for all the ni? spam here--I'm treading in unfamiliar waters.  We should just close this bug as a known issue, then?
Flags: needinfo?(kmaglione+bmo)
FYI: fixed at this unofficial beta version from 2017-03-09 -> https://tampermonkey.net/xpi/46544b6d654f61/firefox-5410beta.xpi

"Unofficial" because the last Tampermonkey update is stuck in the review queue since almost two month and it seems the review can take even a little longer. Sorry for any inconvenience.

https://github.com/Tampermonkey/tampermonkey/issues/368
Given that there's a fixed addon out there, we're going to WONTFIX this.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(kmaglione+bmo)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.