Closed
Bug 1344721
Opened 7 years ago
Closed 7 years ago
Remove null check from Ion post barrier
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
Details
Attachments
(1 file)
|
1.09 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
We need the null check if the value's type is MIRType::ObjectOrNull, but we don't need it in the more common MIRType::Object case.
Attachment #8843977 -
Flags: review?(jcoppeard)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8843977 [details] [diff] [review] Patch Review of attachment 8843977 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #8843977 -
Flags: review?(jcoppeard) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9c62ab1bfb8a Eliminate unnecessary null check from Ion post barriers when we know the object is non-null. r=jonco
|
||
Comment 3•7 years ago
|
||
This patch regressed Octane Deltablue and Richards on AWFY (but only on the Mac 64-bit machine)
|
Assignee | |
Comment 4•7 years ago
|
||
(In reply to Guilherme Lima from comment #3) > This patch regressed Octane Deltablue and Richards on AWFY (but only on the > Mac 64-bit machine) Yeah it's mysterious. The patch just eliminates a test+jump instruction so it must be some kind of caching or alignment issue.
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9c62ab1bfb8a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•