Hi Georg, I would like to take this bug up, can you assign me this bug? Thanks
Created attachment 8844102 [details] [diff] [review] WIP Hi Georg, This an intermediate patch. It's causing almost 26 fails while testing. I will ping you tomorrow in irc. Thanks
What kind of failures is it causing? Can you add some examples?
Created attachment 8846061 [details] [diff] [review] updated patch I have made some changes, which reduced the errors to 2. I now have 2 errors to be resolved. The log is here, http://pasted.co/d1a4255b I cannot find the actual errors / causes. Can you help me? Thanks, Deepa
Yes, I did that. The problem is arising when I change clearCurrentPings() to async. All other methods are all good after changes. Does this information help?
Thanks! I dug a little into that from here and found that this runs into a race condition in the test. We don't want to break anything important here by accident, so we want to take a little time to properly fix this. As we are a work-week currently, we can't fix this right now. So, lets move forward with this patch as-is and i file another bug on changing that function.
Per the above, can you submit a patch with everything except that function changed?
Created attachment 8848572 [details] [diff] [review] final_patch Hi Georg, I have updated the patch.
Thanks Deepa. Just as a note: When you set the review flag i already get mail about it, so in that case there is no need to set the needinfo flag.
Comment on attachment 8848572 [details] [diff] [review] final_patch Review of attachment 8848572 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, that looks good!
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/5f48633cdb53 Update TelemetrySend.jsm to async function & await. r=gfritzsche