Bug 1298950 added support for overriding homepage to chrome_url_overrides. This actually belongs in chrome_settings_overrides where it exists in Chrome. Step one is to back out that patch in preparation for the new patch.
Comment on attachment 8844050 [details] Bug 1344773 - Backout bug 1298950. https://reviewboard.mozilla.org/r/117606/#review119374
Attachment #8844050 - Flags: review?(mixedpuppy) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/e33e742b3302 Backout bug 1298950. r=mixedpuppy
landed on m-c https://hg.mozilla.org/mozilla-central/rev/e33e742b3302
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Can you please request uplift to 54 for this?
Comment on attachment 8844050 [details] Bug 1344773 - Backout bug 1298950. Approval Request Comment [Feature/Bug causing the regression]: This code is using an API that we are going to replace. [User impact if declined]: No user, but API available we don't want exposed. [Is this code covered by automated tests?]: Code is being removed, so there is no test. [Has the fix been verified in Nightly?]: Yes. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Removing code. [String changes made/needed]: None.
Attachment #8844050 - Flags: approval-mozilla-aurora?
Comment on attachment 8844050 [details] Bug 1344773 - Backout bug 1298950. Replace the API we don't want to expose. Aurora54+.
Attachment #8844050 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox54: affected → fixed
You need to log in before you can comment on or make changes to this bug.