1344773 - Back out bug 1298950 in preparation for bug 1341458

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Mike Kaply [:mkaply]]

Bug 1298950 added support for overriding homepage to chrome_url_overrides.

This actually belongs in chrome_settings_overrides where it exists in Chrome.

Step one is to back out that patch in preparation for the new patch.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1344773 - Backout bug 1298950.

Review commit: https://reviewboard.mozilla.org/r/117606/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117606/

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8844050 [details]
Bug 1344773 - Backout bug 1298950.

https://reviewboard.mozilla.org/r/117606/#review119374

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e33e742b3302
Backout bug 1298950. r=mixedpuppy

Comment 4

[Carsten Book [:Tomcat]]

landed on m-c
https://hg.mozilla.org/mozilla-central/rev/e33e742b3302

Comment 5

[Kris Maglione [:kmag]]

Can you please request uplift to 54 for this?

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 8844050 [details]
Bug 1344773 - Backout bug 1298950.

Approval Request Comment
[Feature/Bug causing the regression]: This code is using an API that we are going to replace.
[User impact if declined]: No user, but API available we don't want exposed.
[Is this code covered by automated tests?]: Code is being removed, so there is no test.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Removing code.
[String changes made/needed]: None.

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8844050 [details]
Bug 1344773 - Backout bug 1298950.

Replace the API we don't want to expose. Aurora54+.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/18b3bedeb4be