1344779 - DTDParser has "nothing to repeat" (\s*)? regex

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: compare-locales, defect)

Description

[Axel Hecht [:Pike]]

Turns out the problem I have with python2.7.5 was a simpler one than I thought.

There is an actual (\s*)? part in one of the regexes, and it's not the \specialcars that I thought it was.

I ran this across all of aurora browser without triggering a difference, and added some tests.

Comment 1

[Axel Hecht [:Pike]]

Attachment: bug 1344779, empty regex productions shouldn't be optional,

This replaces (\s*)? with (\s+)?, making the inner of the optional
production non-empty.
Added test to verify that .post content works as expected.

Review commit: https://reviewboard.mozilla.org/r/117598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117598/

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8844038 [details]
bug 1344779, empty regex productions shouldn't be optional,

https://reviewboard.mozilla.org/r/117598/#review119286

Can't spot anything wrong with the approach, also no differences running the parser locally.

Comment 3

[Axel Hecht [:Pike]]

This has been fixed for a while, is released in 1.2.3, and deployed on m-c since this week.