Update in-tree version of compare-locales to 1.2.3

VERIFIED FIXED

Status

VERIFIED FIXED
2 years ago
a year ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

(Blocks: 1 bug)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
+++ This bug was initially created as a clone of Bug #1315976 +++

Let's update to compare-locales 1.2.

With bug 1344779, we'll not need a python update for this :-)

I didn't actually cut the release yet, but once I do, I'll pick this up again.
(Assignee)

Updated

2 years ago
Duplicate of this bug: 1315976
Comment hidden (mozreview-request)
(Assignee)

Comment 3

a year ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6570ef7fefde74439e6b1d8b7489a561622faa6&selectedJob=90954749 is as green as it gets, there are some job-setup related reds there, but we have a green run on each platform, so this should be good to go to prod.

flod, this is ready for review

Comment 4

a year ago
mozreview-review
Comment on attachment 8857477 [details]
bug 1344782, update compare-locales to 1.2.3,

https://reviewboard.mozilla.org/r/129452/#review132058

Double checked the delta between 1.2.1 and 1.2.3, after going through the changes here since I've reviewed some of them before, and everything looks good (besides one small typo that could easily wait a next version)

::: python/compare-locales/compare_locales/compare.py:496
(Diff revision 1)
>                  if isinstance(l10n_entities[l10n_map[item_or_pair]],
>                                parser.Junk):
>                      junk = l10n_entities[l10n_map[item_or_pair]]
> -                    params = (junk.val,) + junk.span
> +                    params = (junk.val,) + junk.position() + junk.position(-1)
>                      self.notify('error', l10n,
> -                                'Unparsed content "%s" at %d-%d' % params)
> +                                'Unparsed content "%s" from line %d colum %d'

typo: column
Attachment #8857477 - Flags: review?(francesco.lodolo) → review+

Comment 5

a year ago
Pushed by axel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/20f442eeb3df
update compare-locales to 1.2.3, r=flod

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/20f442eeb3df
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Comment 7

a year ago
Nightlies are green on all platforms, and I've personally tested the mac builds to be working OK.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.