1344782 - Update in-tree version of compare-locales to 1.2.3

Status: VERIFIED FIXED

(Localization Infrastructure and Tools :: compare-locales, enhancement)

Description

[Axel Hecht [:Pike]]

+++ This bug was initially created as a clone of Bug #1315976 +++

Let's update to compare-locales 1.2.

With bug 1344779, we'll not need a python update for this :-)

I didn't actually cut the release yet, but once I do, I'll pick this up again.

Comment 2

[Axel Hecht [:Pike]]

Attachment: bug 1344782, update compare-locales to 1.2.3,

Dropped support for python 2.6
Removed support for bookmarks.html
Better internal APIs

Intermediate versions had incompatibilities with old versions
of python 2.7, but 1.2.3 does not.

Review commit: https://reviewboard.mozilla.org/r/129452/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129452/

Comment 3

[Axel Hecht [:Pike]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6570ef7fefde74439e6b1d8b7489a561622faa6&selectedJob=90954749 is as green as it gets, there are some job-setup related reds there, but we have a green run on each platform, so this should be good to go to prod.

flod, this is ready for review

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8857477 [details]
bug 1344782, update compare-locales to 1.2.3,

https://reviewboard.mozilla.org/r/129452/#review132058

Double checked the delta between 1.2.1 and 1.2.3, after going through the changes here since I've reviewed some of them before, and everything looks good (besides one small typo that could easily wait a next version)

::: python/compare-locales/compare_locales/compare.py:496
(Diff revision 1)
>                  if isinstance(l10n_entities[l10n_map[item_or_pair]],
>                                parser.Junk):
>                      junk = l10n_entities[l10n_map[item_or_pair]]
> -                    params = (junk.val,) + junk.span
> +                    params = (junk.val,) + junk.position() + junk.position(-1)
>                      self.notify('error', l10n,
> -                                'Unparsed content "%s" at %d-%d' % params)
> +                                'Unparsed content "%s" from line %d colum %d'

typo: column

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20f442eeb3df
update compare-locales to 1.2.3, r=flod

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/20f442eeb3df

Comment 7

[Axel Hecht [:Pike]]

Nightlies are green on all platforms, and I've personally tested the mac builds to be working OK.