1344798 - Improvements to mscom::AsyncInvoker

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[(No longer employed by Mozilla) Aaron Klotz]

When implementing an async call using mscom::AsyncInvoker, it became clear that some improvements needed to be made to the interface.

In particular, it could be possible in a11y to have a pointer to an interface that may or may not be a proxy. That would force us to do something like this:

IFoo* myInterface = ...;

if (IsProxy(myInterface)) {
  ASYNC_INVOKER_FOR(IFoo) invoker(myInterface);
  hr = invoker.Begin_Bar(param1, param2);
} else {
  hr = myInterface->Bar(param1, param2);
}

Which is messy and hard to maintain.

Instead I'm moving that into the AsyncInvoker itself, so that it may just do the right thing depending on whether or not it has an async interface.

Now we can do this:

ASYNC_INVOKER_FOR(IFoo) invoker(myInterface);
hr = ASYNC_INVOKE(myInterface, Bar, param1, param2);

and it just works. It's type-safe too!

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Whoops, that last sample line of code should be:

hr = ASYNC_INVOKE(invoker, Bar, param1, param2);

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Make AsyncInvoker handle both proxied and non-proxied interfaces

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/04b7515972841369d3efc5abc275cdf30b5da143
Bug 1344798: Allow mscom::AsyncInvoker to be able to handle proxied and non-proxied interfaces; r=jimm

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/04b751597284