1344809 - mingw build fails with function 'mozilla::PrintfTarget::PrintfTarget()' definition is marked dllimport

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Tom Ritter [:tjr]]

error: function 'mozilla::PrintfTarget::PrintfTarget()' definition is marked dllimport

It seems mingw must be pickier than our other compilers, as it doesn't like the declaration and the definition in the .h file. Moving it to the cpp works though.

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1344809 Move function definition to cpp to fix mingw 'definition is marked dllimport' error

Review commit: https://reviewboard.mozilla.org/r/117622/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117622/

Comment 2

[Tom Tromey :tromey]

Comment on attachment 8844085 [details]
Bug 1344809 Move function definition to cpp to fix mingw 'definition is marked dllimport' error

https://reviewboard.mozilla.org/r/117622/#review119420

I don't think I can approve changes here, but I do think this is reasonable.
I suggest requesting review from :froydnj instead.

Comment 3

[Tom Ritter [:tjr]]

Hey Nathan, when you unbury yourself could you take a look at this? Thanks!

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8844085 [details]
Bug 1344809 Move function definition to cpp to fix mingw 'definition is marked dllimport' error

https://reviewboard.mozilla.org/r/117622/#review121494

Thanks!

::: mozglue/misc/Printf.cpp:540
(Diff revision 1)
>      }
>  
>      return true;
>  }
>  
> +mozilla::PrintfTarget::PrintfTarget() : mEmitted(0)

Nit: Please format this like so:

mozilla::PrintfTarget::PrintfTarget()
  : mEmitted(0)
{
}

Comment 5

[Tom Ritter [:tjr]]

Comment on attachment 8844085 [details]
Bug 1344809 Move function definition to cpp to fix mingw 'definition is marked dllimport' error

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117622/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58feb843a9ae
Move function definition to cpp to fix mingw 'definition is marked dllimport' error r=froydnj

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/58feb843a9ae