1344833 - Enable flake8 rule E128: "continuation line under-indented for visual indent"

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Alessio Placitelli [:Dexter]]

+++ This bug was initially created as a clone of Bug #1344832 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the E128 rule: "continuation line under-indented for visual indent"

1) Remove the E128 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems

Comment 1

[Federico Padua [:fedepad]]

Done, tests passed (./mach test).
Submitted for review.

Comment 2

[Federico Padua [:fedepad]]

Attachment: Bug 1344833 - Enable flake8 rule E128: "continuation line under-indented for visual indent".

This patch enables flake8 rule E128:
"continuation line under-indented for visual indent" in toolkit/components/telemetry
by removing the relative E128 entry from toolkit/components/telemetry/.flake8
and fixing the files for which the E128 error was reported.
Precisely 10 errors violating E128 rule were found and solved.

Review commit: https://reviewboard.mozilla.org/r/119938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119938/

Comment 3

[Alessio Placitelli [:Dexter]]

Comment on attachment 8846918 [details]
Bug 1344833 - Enable flake8 rule E128: "continuation line under-indented for visual indent".

https://reviewboard.mozilla.org/r/119938/#review123658

This looks good to me, thanks. This will probably need to be rebased once 1344836 lands. Once you rebased, could you please check that linting is still reporting no error?

Comment 4

[Federico Padua [:fedepad]]

Comment on attachment 8846918 [details]
Bug 1344833 - Enable flake8 rule E128: "continuation line under-indented for visual indent".

https://reviewboard.mozilla.org/r/119938/#review123658

Yes, it will need to be rebased...
Sure, I will re-check because I expect that with some of the modifications done by the "Enable flake8 rule" series that have been landing recently there might be the need to re-adjust something for this to report no linting errors.

Comment 5

[Federico Padua [:fedepad]]

Comment on attachment 8846918 [details]
Bug 1344833 - Enable flake8 rule E128: "continuation line under-indented for visual indent".

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/119938/diff/1-2/

Comment 6

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 09e3abb5c142 -d 42e118e10c22: rebasing 382869:09e3abb5c142 "Bug 1344833 - Enable flake8 rule E128: "continuation line under-indented for visual indent". r=Dexter" (tip)
merging toolkit/components/telemetry/.flake8
merging toolkit/components/telemetry/histogram_tools.py
warning: conflicts while merging toolkit/components/telemetry/.flake8! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 7

[Alessio Placitelli [:Dexter]]

Looks like this needs to be rebased, again. Darn flake8!

Comment 8

[Federico Padua [:fedepad]]

Comment on attachment 8846918 [details]
Bug 1344833 - Enable flake8 rule E128: "continuation line under-indented for visual indent".

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/119938/diff/2-3/

Comment 9

[Federico Padua [:fedepad]]

Comment on attachment 8846918 [details]
Bug 1344833 - Enable flake8 rule E128: "continuation line under-indented for visual indent".

https://reviewboard.mozilla.org/r/119938/#review123658

Rebased again, so you should be able to merge now...I hope ;)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c20d53a06dc
Enable flake8 rule E128: "continuation line under-indented for visual indent". r=Dexter

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0c20d53a06dc