1344846 - Enable flake8 rule E203: "whitespace before ':'"

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Alessio Placitelli [:Dexter]]

+++ This bug was initially created as a clone of Bug #1344844 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the E203, "whitespace before ':'":

1) Remove the E203 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems

Comment 1

[Deepjyoti Mondal]

Attachment: bug1344846.patch

Removed whitespace present before :, test is passing.

Comment 2

[Alessio Placitelli [:Dexter]]

Comment on attachment 8845499 [details] [diff] [review]
bug1344846.patch

Review of attachment 8845499 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks.

However, this doesn't apply cleanly to the most recent mozilla-central. Please rebase your patch.

Comment 3

[Deepjyoti Mondal]

Attachment: bug1344846.patch

Updated my mozilla-central repo.

Comment 4

[Alessio Placitelli [:Dexter]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3749bd0c914061acae85241cca2bf084f23b3d78
Bug 1344846 - Enable flake8 rule E203: "whitespace before ':'". r=dexter

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3749bd0c9140