Enable flake8 rule E203: "whitespace before ':'"

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Telemetry
P3
normal
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: Dexter, Assigned: Deepjyoti Mondal, Mentored)

Tracking

Trunk
mozilla55
Points:
1
Dependency tree / graph

Firefox Tracking Flags

(firefox54 wontfix, firefox55 fixed)

Details

(Whiteboard: [measurement:client][lang=python])

Attachments

(1 attachment, 1 obsolete attachment)

+++ This bug was initially created as a clone of Bug #1344844 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the E203, "whitespace before ':'":

1) Remove the E203 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems
No longer depends on: 1344844
Blocks: 1344849
No longer blocks: 1344849
(Assignee)

Comment 1

a year ago
Created attachment 8845499 [details] [diff] [review]
bug1344846.patch

Removed whitespace present before :, test is passing.
Attachment #8845499 - Flags: review?(alessio.placitelli)
Assignee: nobody → djmdeveloper060796
Comment on attachment 8845499 [details] [diff] [review]
bug1344846.patch

Review of attachment 8845499 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks.

However, this doesn't apply cleanly to the most recent mozilla-central. Please rebase your patch.
Attachment #8845499 - Flags: review?(alessio.placitelli) → review+
(Assignee)

Comment 3

a year ago
Created attachment 8845666 [details] [diff] [review]
bug1344846.patch

Updated my mozilla-central repo.
Attachment #8845499 - Attachment is obsolete: true
Flags: needinfo?(alessio.placitelli)
Attachment #8845666 - Flags: review+
Flags: needinfo?(alessio.placitelli)

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3749bd0c9140
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
status-firefox54: affected → wontfix
You need to log in before you can comment on or make changes to this bug.