1344864 - In the signature view, display a red banner to alert that it is a startup crash

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P2)

Description

[Sylvestre Ledru [:Sylvestre]]

Now that we have a marker to know if it is an actual startup crash, we should display a red banner to clearly show that it is a startup crash.

Otherwise, it is hard to know that they might be.

We should NOT do that if crashes are coming from plugins.

Comment 1

[Aditya Motwani (:AdityaM)]

I would like to work on this bug.

I am a newbie on Socorro, So I'm not sure where the marker for startup crash is present. Any help on that would be great!

Please assign this bug to me.

Comment 2

[Marco Castelluccio [:marco]]

The logic should be similar to the one that adds the startup crash icons on the top crashers list:
https://github.com/mozilla/socorro/blob/2b551320c35a49ba8cc628630d3122fb1df1f9a4/webapp-django/crashstats/topcrashers/views.py#L107
https://github.com/mozilla/socorro/blob/2b551320c35a49ba8cc628630d3122fb1df1f9a4/webapp-django/crashstats/topcrashers/jinja2/topcrashers/topcrashers.html#L161

Here's another example usage of the StartupCrash field, this time for a specific crash report: https://github.com/mozilla/socorro/blob/2b551320c35a49ba8cc628630d3122fb1df1f9a4/webapp-django/crashstats/crashstats/jinja2/crashstats/report_index.html#L256.
This shows up in the metadata section of the report view ("StartupCrash: 1"): https://crash-stats.mozilla.com/report/index/1fa2b7d6-2e07-41ed-84cb-b0fd52170310#tab-metadata.

You would need to add the banner on the signature view: https://crash-stats.mozilla.com/signature/?signature=nsDependentCString%3A%3AnsDependentCString.
In the Socorro source code, this is at https://github.com/mozilla/socorro/blob/2b551320c35a49ba8cc628630d3122fb1df1f9a4/webapp-django/crashstats/signature/jinja2/signature/signature_report.html.

Comment 3

[Aditya Motwani (:AdityaM)]

Thanks for your help!

Should I add the red-banner if 'startup_count' = Total number of crashes or when 'startup_crash' is true [ More than half the crashes happened within one minute of startup ] ?

Comment 4

[Marco Castelluccio [:marco]]

(In reply to Aditya Motwani (:AdityaM) from comment #3)
> Thanks for your help!
> 
> Should I add the red-banner if 'startup_count' = Total number of crashes or
> when 'startup_crash' is true [ More than half the crashes happened within
> one minute of startup ] ?

I would add the red banner if startup_count > 0, saying "Startup Crash, all crashes happened during startup" if startup_count = total number of crashes or "Potential Startup Crash, {{ crash.startup_count }} out of {{ crash.count }} crashes happened during startup" otherwise.
Let's ask Adrian for his opinion.

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

So, in terms of UI, I'm not too sure how we should display that. I'm going to wait for your suggestions Aditya, but since I am quite opinionated I might disagree. :D

I think having the distinction between "startup crash" and "potential startup crash" is interesting, if we can find a good way to show that on the page.

Comment 6

[Aditya Motwani (:AdityaM)]

Thank you Adrian for your input and help! I am working with the views currently and will get to the banner shortly.

I would like to summarize this for Marco before I continue.

I spoke with Adrian on #breakpad and he said that we need to make a separate view for this and then import it to the signature_report view as we need to make an ajax call to the database as this information is not present in the "context" variable.

This view will do a SuperSearch query to get meta data and then we can determine if it is a startup crash.

Any ideas if there is a better way or if this is the only way to go?

Comment 7

[Marco Castelluccio [:marco]]

Sorry, I forgot to reply here. I agree with Adrian, he has a lot more experience with Socorro than me :)

Comment 8

[Calixte Denizet (:calixte)]

Be able to distinguish quickly a startup crash is very important.
:willkg, could you help here ?

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

Is the idea for this bug "Show a red banner above the "Signature report for <signature>" text for all tabs on the signature report page"?

Adrian had this url: https://crash-stats.mozilla.com/signature/?signature=nsDependentCString%3A%3AnsDependentCString

That seems doable. I'll toss this in the queue. It'd be great if someone else could get to this, because we've got a big queue and not many people working on it.

Comment 10

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'm having a "nothing is working" Friday. I'll see if I can tackle this now.

Comment 11

[Will Kahn-Greene [:willkg] ET needinfo? me]

Comment #6 seems right on. The signature report page will load, then have to do an AJAX call to figure out whether all crashes are startup crashes or some crashes are startup crashes or none of the crashes are startup crashes. Then it'll get back this information and surface it in some way.

I haven't looked at the signature report code before, so I think this is going to take me a while to figure out. I'll spend some more time on it next week.

Comment 12

[Will Kahn-Greene [:willkg] ET needinfo? me]

Unassigning myself from bugs I'm not immediately working on and/or have some meaningful progress on.

Comment 13

[Alexis Deschamps [:alexisdeschamps]]

How about adding the same flag and/or rocket ship icons indicating startup crashes found on the top crashers page to the signature page?

Comment 14

[Marco Castelluccio [:marco]]

I think anything works, as long as it is *very* noticeable :)

Comment 15

[Alexis Deschamps [:alexisdeschamps]]

Here is what the updated page could look like: https://user-images.githubusercontent.com/12681350/42000011-33b969e0-7a14-11e8-9851-608e17e738f0.png. They are the same icons as those found on the top crashers page and, thus, have tooltips with extra information.

Would this be suitable? The same icons could also be added to the Super Search results page.

Comment 16

[Marco Castelluccio [:marco]]

(In reply to Alexis Deschamps [:alexisdeschamps] from comment #15)
> Here is what the updated page could look like:
> https://user-images.githubusercontent.com/12681350/42000011-33b969e0-7a14-
> 11e8-9851-608e17e738f0.png. They are the same icons as those found on the
> top crashers page and, thus, have tooltips with extra information.
> 
> Would this be suitable? The same icons could also be added to the Super
> Search results page.

It might be a bit too subtle, but maybe it is enough. Let's ask some people who look at crashes very often.

Comment 17

[Marcia Knous [:marcia]]

I agree with Comment 14, as long as it is easily noticeable it is fine with me.

Comment 18

[[:philipp]]

i would think a disclaimer should be even more prominent, so that it catches the attention of the occasional visitor to a signature summary page too - as people looking at crash reports frequently probably already are aware of how to spot them today.

(also the rocket icon may become a bit confusing, as we have a product with the same name / similar visual assets now)

Comment 19

[Alexis Deschamps [:alexisdeschamps]]

Would the following be acceptable as a warning that the crash is a startup crash: https://user-images.githubusercontent.com/12681350/42117787-a8ac47fe-7bb3-11e8-89dd-beb7b53559f5.png?

Would it also be OK for the warning to only be under the summary tab as opposed to under the signature and visible from every tab?

Comment 20

[[:philipp]]

yes thanks, that looks catchy enough and i think it's ok just having it on the summary page.

Comment 21

[Sylvestre Ledru [:Sylvestre]]

Would be perfect! Many thanks for doing that!

Comment 22

[Marco Castelluccio [:marco]]

Looks good to me!

Comment 23

[Calixte Denizet (:calixte)]

lgtm too, thanks.

Comment 24

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/d84709b1e2231f64d036e34fb8e90f0ed73b653f
bug 1344864: refactored topcrashers

why:
- needed to extract some of the functionality used to generate topcrashers data because part of it will be used to generate signature summary data

what:
- refacted topcrashers
  - started generating data through classes instead of a dictionary
  - extracted computations into methods

https://github.com/mozilla-services/socorro/commit/4c92cecc5026f75c4a739d34159452fb906049b0
fix bug 1344864: added startup stats sig summary

why:
- being able to distinguish startup crashes from non-startup crashes is useful

what:
- added icons and text to the signature summary tab that indicate startup crash statistics
  - these are the same icons as those found on the topcrashers page

https://github.com/mozilla-services/socorro/commit/9d6160b43a05eb79ad8801f56b6f4b52868179ed
fix bug 1344864: added review updates

- converted topcrashers signature icons into macros
    - started using these macros in the topcrashers page
    - started using these macros in signature summary
- updated SignatureStats class
    - merged SignatureStartupStats into SignatureStats
    - started doing the previous results checks through properties instead of after the fact
    - made all properties be cached_property's
    - changed properties for startup, hang, and plugin stats to be booleans instead of numbers
    - added unit test
- updated signature summary
    - added custom LESS classes to change color and layout
- updated topcrashers
    - removed `get_signatures_stats` util method and started doing the work in views.py instead
    - change variable naming to be simpler and more informative

https://github.com/mozilla-services/socorro/commit/c2bb2bea29ce6a85a9eaab99047db6e354643a0a
fix bug 1344864: added review updates

- changed name of items when looping over `topcrashers_stats` for better clarity
- removed redundant line in `topcrashers/views.py `

https://github.com/mozilla-services/socorro/commit/1b9d051717d83d64699a40b2998d33568ffca926
Merge pull request #4506 from mozilla-services/signature-startup-stats

fix bug 1344864: added startup stats to the signature summary