Closed
Bug 1344900
Opened 7 years ago
Closed 7 years ago
CSS touchups for Synced Tabs when Tab Syncing disabled
Categories
(Firefox :: Sync, defect, P3)
Tracking
()
VERIFIED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | verified |
People
(Reporter: eoger, Assigned: kurshakovakristina, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(4 files)
When the synced tabs button is put in the toolbar, and open tabs syncing is disabled, the "Sync preferences" button is not aligned (and neither the sync illustration I think). (see tofix_intoolbar.png) The problem arises too when the synced tabs button is in the hamburger menu, but too a lesser extent. (see tofix_inpanel.png) We have to be careful when fixing this, because the non-signed in view, which doesn't have this alignment problem, could be affected (see signin).
Reporter | ||
Comment 1•7 years ago
|
||
Reporter | ||
Comment 2•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Hi, I do not see this problem in Linux. Are you sure there is a problem with it?
Reporter | ||
Comment 4•7 years ago
|
||
Good find, I tried on Ubuntu and Windows and couldn't reproduce. Marking this but as MacOS only.
OS: Unspecified → Mac OS X
Assignee | ||
Comment 5•7 years ago
|
||
Hey, I think I fixed the bug. Can someone assign this bug to me?
Comment 6•7 years ago
|
||
(In reply to Kristina Kurshakova from comment #5) > Hey, I think I fixed the bug. Can someone assign this bug to me? Done!
Assignee: nobody → kurshakovakristina
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
Hi there, I pushed my fix, could you help me with the next step?
Flags: needinfo?(eoger)
Reporter | ||
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8859686 [details] Bug 1344900 - Center remote tabs panel when tab syncing disabled. https://reviewboard.mozilla.org/r/131704/#review134494 Well I must say I wasn't expecting a one-line-patch for this :) I also tested this on Windows and I didn't notice any regression. Thank you for the patch, please fix the commit message and I'll land this for you. ::: commit-message-ef8d1:1 (Diff revision 1) > +Bug 1344900 - Toolbar -> Synced Tabs -> "Sync Preferences" align button to center Reword this to "Bug 1344900 - Center remote tabs panel when tab syncing disabled. r?eoger"
Attachment #8859686 -
Flags: review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 11•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8859686 [details] Bug 1344900 - Center remote tabs panel when tab syncing disabled. https://reviewboard.mozilla.org/r/131704/#review134494 Thanks Edouard! I'm done with commit message.
Comment 12•7 years ago
|
||
Pushed by eoger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/79d38eed0b73 Center remote tabs panel when tab syncing disabled. r=eoger
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/79d38eed0b73
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Reporter | ||
Comment 14•7 years ago
|
||
And it's merged! Thank you for your contribution Kristina.
Flags: needinfo?(eoger)
Assignee | ||
Comment 15•7 years ago
|
||
@Eduardo Cool! Thanks guys for assisting my first bug!
Comment 16•7 years ago
|
||
I managed to reproduce this bug on Nightly from 2017-03-06 using Mac OS x 10.11. I retested it on the latest Nightly and Firefox 55.0b13 using the same platform and the bug is not reproducing anymore. I think that it's fixed.
Comment 17•7 years ago
|
||
Thanks Oana, I'll mark this as verified fixed based on your testing.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•