1344901 - Fix a regression from bug 1337551

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

I just landed bug 1337551 and noticed that I called `GetSystemLocale()` in it, while our API has `GetSystemLocales()` and `systemLocale` property.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1344901 - Fix a regression introduced in bug 1337551.

Review commit: https://reviewboard.mozilla.org/r/117704/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117704/

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

We may have to backport it to aurora since today is the merge day.

Comment 3

[Jonathan Kew [:jfkthame]]

Comment on attachment 8844172 [details]
Bug 1344901 - Fix a regression introduced in bug 1337551.

https://reviewboard.mozilla.org/r/117704/#review119404

Oops!

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8844172 [details]
Bug 1344901 - Fix a regression introduced in bug 1337551.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1337551
[User impact if declined]: in some scenarios, users who want to match their locale to the OS will not be able too. There may also be exceptions.
[Is this code covered by automated tests?]: badly as indicated by the fact that I landed the regression green.
[Has the fix been verified in Nightly?]: Yep.
[Needs manual test from QE? If yes, steps to reproduce]: No, I tested it locally
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: no
[Why is the change risky/not risky?]: Because it's a trivial change of the property name in 4 places from a property that doesn't exist, to one that does.
[String changes made/needed]: None

Comment 6

[Jan Beich]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #4)
> [Has the fix been verified in Nightly?]: Yep.

Where did this land? I don't see a link to central, not to mention autoland/inbound commit.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1b9ef9ab95d
Fix a regression introduced in bug 1337551. r=jfkthame

Comment 8

[Gerry Chang [:gchang]]

Hi :zibi,
Since yesterday was merge day, I'm not sure if you request for Beta53 or Aurora54 uplift? If you want to request for 53, you can create another Beta53 uplift request.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e1b9ef9ab95d

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

:gchang, yes, this is for 54, sorry for confusion!

Comment 12

[Gerry Chang [:gchang]]

Comment on attachment 8844172 [details]
Bug 1344901 - Fix a regression introduced in bug 1337551.

Fix a regression. Aurora54+.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/31cd77685e1c