Closed Bug 1344903 Opened 3 years ago Closed 3 years ago

Renew Geo probes

Categories

(Core :: DOM: Geolocation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mds, Assigned: mds)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8844173 [details]
Bug 1344903 - Renew Geo probes.

https://reviewboard.mozilla.org/r/117708/#review121132

Although the bug was filed without any comments, I'm guessing this means the team is still actively using this data. So I'm going to mark data-r+ based on that, but in the future it would be nice to be more explicit about that.
Attachment #8844173 - Flags: review?(benjamin) → review+
(In reply to Benjamin Smedberg [:bsmedberg] from comment #4)

> Although the bug was filed without any comments, I'm guessing this means the
> team is still actively using this data. So I'm going to mark data-r+ based
> on that, but in the future it would be nice to be more explicit about that.

Will certainly do, thanks!
Backed out for build bustage (histogram not removed from whitelist and according to new temporary policy, I shall not push fixes on autoland so the impact of such a tightened policy can be measure):

https://hg.mozilla.org/integration/autoland/rev/1d9f1d45ac6e98efc78517ba3392ba11e4e24faf

Push with failures (we had some other bustage before that): https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d983cb91c5a48243adcd13187f4ae9f623f3d0d0&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=83431021&repo=autoland
>Should remove histogram "GEOLOCATION_GETCURRENTPOSITION_SECURE_ORIGIN" from the whitelist for "alert_emails" in histogram-whitelists.json'
Flags: needinfo?(mdesimone)
When things appear too simple to try-run...:-/
Updated and trying before re-autolanding.

Sorry for the snafu :aryx.
Flags: needinfo?(mdesimone)
https://hg.mozilla.org/mozilla-central/rev/e64c354ca87b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.