1344903 - Renew Geo probes

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, enhancement)

Comment 1

[Michelangelo De Simone [Offline] [:mds]]

Attachment: Bug 1344903 - Renew Geo probes.

Review commit: https://reviewboard.mozilla.org/r/117708/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117708/

Comment 2

[Michelangelo De Simone [Offline] [:mds]]

Comment on attachment 8844173 [details]
Bug 1344903 - Renew Geo probes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117708/diff/1-2/

Comment 3

[Michelangelo De Simone [Offline] [:mds]]

Comment on attachment 8844173 [details]
Bug 1344903 - Renew Geo probes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117708/diff/2-3/

Comment 4

[Benjamin Smedberg]

Comment on attachment 8844173 [details]
Bug 1344903 - Renew Geo probes.

https://reviewboard.mozilla.org/r/117708/#review121132

Although the bug was filed without any comments, I'm guessing this means the team is still actively using this data. So I'm going to mark data-r+ based on that, but in the future it would be nice to be more explicit about that.

Comment 5

[Michelangelo De Simone [Offline] [:mds]]

(In reply to Benjamin Smedberg [:bsmedberg] from comment #4)

> Although the bug was filed without any comments, I'm guessing this means the
> team is still actively using this data. So I'm going to mark data-r+ based
> on that, but in the future it would be nice to be more explicit about that.

Will certainly do, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19a4d023dd56
Renew Geo probes. r=bsmedberg

Comment 7

[Sebastian Hengst [:aryx] [limited availability until start of 2020] (needinfo on intermittent or backout)]

Backed out for build bustage (histogram not removed from whitelist and according to new temporary policy, I shall not push fixes on autoland so the impact of such a tightened policy can be measure):

https://hg.mozilla.org/integration/autoland/rev/1d9f1d45ac6e98efc78517ba3392ba11e4e24faf

Push with failures (we had some other bustage before that): https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d983cb91c5a48243adcd13187f4ae9f623f3d0d0&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=83431021&repo=autoland
>Should remove histogram "GEOLOCATION_GETCURRENTPOSITION_SECURE_ORIGIN" from the whitelist for "alert_emails" in histogram-whitelists.json'

Comment 8

[Michelangelo De Simone [Offline] [:mds]]

Comment on attachment 8844173 [details]
Bug 1344903 - Renew Geo probes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117708/diff/3-4/

Comment 9

[Michelangelo De Simone [Offline] [:mds]]

When things appear too simple to try-run...:-/
Updated and trying before re-autolanding.

Sorry for the snafu :aryx.

Comment 10

[Michelangelo De Simone [Offline] [:mds]]

Comment on attachment 8844173 [details]
Bug 1344903 - Renew Geo probes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117708/diff/4-5/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e64c354ca87b
Renew Geo probes. r=bsmedberg

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e64c354ca87b