1344917 - Need to know when Windows is configured to color the title bars

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

In Windows 10 (and perhaps lower), there's a user setting for putting an accent colour in the title bar of windowed applications.

For proper integration, we should detect that setting and colour our title bar appropriately.

Comment 1

[Justin Dolske [:Dolske]]

Dao: it's not clear we have a bug to actually use this info in the theme (similarly for bug 1344910), can we get that filed w/ relevant UX spec?

Comment 2

[Dão Gottwald [:dao]]

Yep, will do.

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: part 1 - Implement a '-moz-windows-accent-color-applies' media query

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: part 2 - Add some tests for the '-moz-windows-accent-color-applies' media query

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/352c30687dea
part 1 - Add a '-moz-windows-accent-color-applies' media query. r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1e72c299049
part 2 - Add tests for the '-moz-windows-accent-color-applies' media query. r=heycam

Comment 6

[Carsten Book [:Tomcat]]

sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=71444e81ac24f74179aed226fcbd90f463460c9b&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception since one of the changes caused crashes like https://treeherder.mozilla.org/logviewer.html#?job_id=108844802&repo=mozilla-inbound

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8833925adae5
Backed out changeset b1e72c299049 
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8c39cd57115
Backed out changeset 352c30687dea

Comment 8

[Jonathan Watt [:jwatt]]

That crash wasn't caused by the patches here (it was caused by the patch for bug 1369508). That said, this bug did cause tier 2 stylo failures. Simon has written a stylo patch to fix those issues at https://github.com/servo/servo/pull/17449/ and once that has the necessary reviews we can reland this patch and that one together.

Comment 9

[Jonathan Watt [:jwatt]]

Because these changes need to be synchronized with Servo changes it seems like I'll need to use MozReview so that I can land using Autoland. I'll put up MozReview patches and r+ them ready for landing shortly.

Comment 10

[Jonathan Watt [:jwatt]]

Attachment: Bug 1344917, part 1 - Add a '-moz-windows-accent-color-applies' media query.

The '-moz-windows-accent-color-applies' media query matches when the Windows 10
accent color should be used as the background of the title bar.

Review commit: https://reviewboard.mozilla.org/r/152786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152786/

Comment 11

[Jonathan Watt [:jwatt]]

Attachment: Bug 1344917, part 2 - Add tests for the '-moz-windows-accent-color-applies' media query.

Review commit: https://reviewboard.mozilla.org/r/152788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152788/

Comment 12

[Cameron McCormack (:heycam)]

Comment on attachment 8881623 [details]
Bug 1344917, part 1 - Add a '-moz-windows-accent-color-applies' media query.

https://reviewboard.mozilla.org/r/152786/#review157908

Comment 13

[Cameron McCormack (:heycam)]

Comment on attachment 8881624 [details]
Bug 1344917, part 2 - Add tests for the '-moz-windows-accent-color-applies' media query.

https://reviewboard.mozilla.org/r/152788/#review157910

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d07b25fd6533
part 1 - Add a '-moz-windows-accent-color-applies' media query. r=heycam
https://hg.mozilla.org/integration/autoland/rev/d7dca95a5bc8
part 2 - Add tests for the '-moz-windows-accent-color-applies' media query. r=heycam

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d07b25fd6533
https://hg.mozilla.org/mozilla-central/rev/d7dca95a5bc8

Comment 16

[My1]

sorry for asking but why is it even needed for firefox to know the system color or anything, I mean how did firefox never have a problem in older OSes than windows 10? and why not use that way?

Comment 17

[Chris Mills [:cmills]]

This is documented; see https://bugzilla.mozilla.org/show_bug.cgi?id=1344910#c27