Need to know when Windows is configured to color the title bars

ASSIGNED
Assigned to

Status

()

Core
Widget: Win32
P1
normal
ASSIGNED
4 months ago
4 days ago

People

(Reporter: mconley, Assigned: jwatt)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

unspecified
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [photon-visual][p1][tpi:+])

Attachments

(2 attachments)

(Reporter)

Description

4 months ago
In Windows 10 (and perhaps lower), there's a user setting for putting an accent colour in the title bar of windowed applications.

For proper integration, we should detect that setting and colour our title bar appropriately.

Updated

4 months ago
Priority: -- → P3
Whiteboard: tpi:+
Dao: it's not clear we have a bug to actually use this info in the theme (similarly for bug 1344910), can we get that filed w/ relevant UX spec?
Flags: needinfo?(dao+bmo)

Comment 2

3 months ago
Yep, will do.
Flags: needinfo?(dao+bmo)

Updated

3 months ago
Blocks: 1196266

Updated

3 months ago
No longer blocks: 1325171

Updated

3 months ago
Priority: P3 → P1
Whiteboard: tpi:+ → [tpi:+][photon]

Updated

2 months ago
Whiteboard: [tpi:+][photon] → [tpi:+][photon-visual]

Updated

2 months ago
Flags: qe-verify-
Priority: P1 → P2

Updated

2 months ago
Whiteboard: [tpi:+][photon-visual] → [photon-visual][p1][tpi:+]
(Assignee)

Updated

5 days ago
Assignee: nobody → jwatt
Status: NEW → ASSIGNED
Priority: P2 → P1
(Assignee)

Comment 3

4 days ago
Created attachment 8879765 [details] [diff] [review]
part 1 - Implement a '-moz-windows-accent-color-applies' media query
Attachment #8879765 - Flags: review?(cam)
(Assignee)

Comment 4

4 days ago
Created attachment 8879766 [details] [diff] [review]
part 2 - Add some tests for the '-moz-windows-accent-color-applies' media query
Attachment #8879766 - Flags: review?(cam)
Attachment #8879765 - Flags: review?(cam) → review+
Attachment #8879766 - Flags: review?(cam) → review+

Comment 5

4 days ago
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/352c30687dea
part 1 - Add a '-moz-windows-accent-color-applies' media query. r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1e72c299049
part 2 - Add tests for the '-moz-windows-accent-color-applies' media query. r=heycam
sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=71444e81ac24f74179aed226fcbd90f463460c9b&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception since one of the changes caused crashes like https://treeherder.mozilla.org/logviewer.html#?job_id=108844802&repo=mozilla-inbound
Flags: needinfo?(jwatt)

Comment 7

4 days ago
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8833925adae5
Backed out changeset b1e72c299049 
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8c39cd57115
Backed out changeset 352c30687dea
(Assignee)

Comment 8

4 days ago
That crash wasn't caused by the patches here (it was caused by the patch for bug 1369508). That said, this bug did cause tier 2 stylo failures. Simon has written a stylo patch to fix those issues at https://github.com/servo/servo/pull/17449/ and once that has the necessary reviews we can reland this patch and that one together.
Flags: needinfo?(jwatt)
You need to log in before you can comment on or make changes to this bug.