1344942 - Allow JS plugins to load a Pepper library in a separate process and provide IPC to it

Status: RESOLVED WONTFIX

(Core Graveyard :: Plug-ins, defect, P2)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 1

[Evelyn Hung]

Comment on attachment 8844228 [details] [diff] [review]
v1

Review of attachment 8844228 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PPAPIJSProcessChild.cpp
@@ +212,5 @@
> +      }
> +    }
> +  }
> +
> +  if (!mRPCLibrary || !mPluginLibrary) {

It's hard to debug from the logs when process is killed because of missing libraries. It will be very helpful if we can add a debug message here to make it more obvious.

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: Support async IPDL methods returning values that can only be moved, not copied (like ipc::EndPoint)

ipc::EndPoint can't be copied, only moved (and we probably want to keep it that way). Async IPDL methods returning a value use MozPromise. Some of the generated C++ copies where it could just move. We also generate a MozPromise with IsExclusive set to false, which means the MozPromise code uses copy and not move. The patch makes the generated code move the value, and sets IsExclusive to true if any of the return values are ipc::EndPoint. We could set IsExclusive to true for all async methods with a return value, but I'm not sure that we want to restrict all callers that way.

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: Allow JS plugins to load a Pepper library in a separate process and provide IPC to it

Let me know if you're too busy and I should look for a different reviewer.

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Hi Peter. I'm sorry it's taken me so long to realize that I don't have time to do this. Kan-Ru might be able to review.

Comment 6

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 8869510 [details] [diff] [review]
Support async IPDL methods returning values that can only be moved, not copied (like ipc::EndPoint)

Review of attachment 8869510 [details] [diff] [review]:
-----------------------------------------------------------------

In bug 1255894 :kmag fixed this.

Comment 7

[Kan-Ru Chen [:kanru] (UTC+9)]

Peter, I'm sorry it took me so long to this. Do you still want the patch reviewed? Maybe we can keep the jsplugin part. I'm not sure if we still want to ship that feature though.

Comment 8

[Peter Van der Beken [:peterv]]

Ugh, I didn't know this was still in review (didn't show up in my list).