Closed Bug 1344963 Opened 3 years ago Closed 3 years ago

add --ignore-closed-tree option to l10n-bumper.py

Categories

(Release Engineering :: Release Automation: Other, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aki, Assigned: aki)

Details

Attachments

(3 files)

By default, l10n-bumper is noop when the tree is closed.  We run a treestatus action that exits if the tree is closed, and we don't include a CLOSED TREE commit message, should the tree become closed between the check and the push.  This is probably the best automated behavior, because we want a way to easily stop the l10n bumper from landing changes and tree closure is a natural and intuitive way to do so.

However, on merge day, we want to keep the tree closed, while landing merge day changes with CLOSED TREE.  So let's add a --ignore-tree-closure cmdln option, and have that do the right things.  We can update the merge day docs with this for when we run l10n-bumper manually.
Keywords: leave-open
Comment on attachment 8844264 [details]
bug 1344963 - add --ignore-tree-closure option to l10n-bumper.py.

https://reviewboard.mozilla.org/r/117768/#review119458
Attachment #8844264 - Flags: review?(rail) → review+
Pushed by asasaki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1fbb11dd840
add --ignore-tree-closure option to l10n-bumper.py. r=rail
Priority: -- → P1
Attached patch fix_bumper.diffSplinter Review
Attachment #8851832 - Flags: review?(rail)
Attachment #8851832 - Flags: review?(rail) → review+
Attached patch bump-bumper.diffSplinter Review
This will update each l10n-bumper instance to the latest l10n-bumper changeset, allowing us to use --ignore-closed-tree.
Attachment #8854204 - Flags: review?(bugspam.Callek)
Summary: add --ignore-tree-closure type option to l10n-bumper.py → add --ignore-closed-tree option to l10n-bumper.py
Attachment #8854204 - Flags: review?(bugspam.Callek) → review+
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.