Closed Bug 1344981 Opened 3 years ago Closed 3 years ago

Disable 'privacy.trackingprotection.annotate_channels' in aurora

Categories

(Toolkit :: Safe Browsing, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed
firefox55 --- wontfix

People

(Reporter: hchang, Assigned: dimi)

Details

Attachments

(1 file)

Priority: -- → P1
This will be a partial backout of bug 1334241 / changeset e183f45318c8.

We shouldn't backout the reftest fix that was included there.
Assignee: nobody → tnguyen
Status: NEW → ASSIGNED
Assignee: tnguyen → dlee
The changes made in bug 1334241 are not yet merged to beta, so only fix this in aurora.
Summary: Disable 'privacy.trackingprotection.annotate_channels' in beta → Disable 'privacy.trackingprotection.annotate_channels' in aurora
Attachment #8849430 - Flags: review?(francois)
Comment on attachment 8849430 [details]
Bug 1344981 - Disable 'privacy.trackingprotection.annotate_channels' in aurora

https://reviewboard.mozilla.org/r/122194/#review124456
Attachment #8849430 - Flags: review?(francois) → review+
Comment on attachment 8849430 [details]
Bug 1344981 - Disable 'privacy.trackingprotection.annotate_channels' in aurora

Approval Request Comment
[Feature/Bug causing the regression]: This was enabled in bug 1334241 and caused bug 1325054.
[User impact if declined]: Hangs / perf regressions
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: It's not in Nightly.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: It's only disabling a feature that (in hindsight) got enabled too quickly.
[String changes made/needed]: None
Attachment #8849430 - Flags: approval-mozilla-aurora?
Comment on attachment 8849430 [details]
Bug 1344981 - Disable 'privacy.trackingprotection.annotate_channels' in aurora

Disable 'privacy.trackingprotection.annotate_channels' in aurora to avoid the perf regression. Aurora54+.
Attachment #8849430 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/359ce548deb8
Disable 'privacy.trackingprotection.annotate_channels' in aurora r=francois
Keywords: checkin-needed
(In reply to Pulsebot from comment #7)
> Pushed by cbook@mozilla.com:
> https://hg.mozilla.org/integration/autoland/rev/359ce548deb8
> Disable 'privacy.trackingprotection.annotate_channels' in aurora r=francois

Quite certain this wasn't supposed to ever land on mozilla-central...
Flags: needinfo?(cbook)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Flags: needinfo?(cbook)
You need to log in before you can comment on or make changes to this bug.