Status: UNCONFIRMED → NEW
tracking-fxios: --- → ?
Ever confirmed: true
Comment on attachment 8844305 [details] [review] Pull request Thanks for the patch Kyle! I'm going to forward to James who has handled the password manager stuff in the past.
Attachment #8844305 - Flags: review?(sleroux) → review?(jhugman)
tracking-fxios: ? → +
Priority: -- → P2
Comment on attachment 8844305 [details] [review] Pull request Reviewed, approved and merged. Thank you so much for your contribution!
Attachment #8844305 - Flags: review?(jhugman) → review+
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Hey guys, How do I figure out what production version this PR is targeted to? I'm trying to test this with the version in the app store today (7.3, 2772) and I cannot get it working.
Hey Kyle Looks like this didn't make the cut for 7.x, as per https://github.com/kspearrin/firefox-ios/blob/v7.x/Client/Frontend/Share/ShareExtensionHelper.swift#L126 It's on master currently so it should be released with 8.0, which is entering the beta period shortly.
Thanks Aaron! I'll stop chasing Ghost bugs now :)
master link @ https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Frontend/Share/ShareExtensionHelper.swift#L130 (currently v8.0)
You need to log in before you can comment on or make changes to this bug.