1345005 - Ensure validation prefs are set for all tests that run a full sync

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Lina Butler [:lina]]

Some of our tests call `Svc.Prefs.resetBranch("")` or `Service.startOver()`, which resets the validation prefs to their default values. I stumbled on this figuring out why I wasn't seeing validation results when I uncommented a test above the one I changed in bug 1335891. This patch makes it a bit more explicit which tests perform a full sync, and should run validation.

Comment 1

[Lina Butler [:lina]]

Attachment: Bug 1345005 - Ensure validation prefs are set for all tests that run a full sync.

Some of our tests call `Svc.Prefs.resetBranch("")` or
`Service.startOver()`, which resets the validation prefs to their
default values. This patch makes it a bit more explicit which tests
perform a full sync, and should run validation.

Review commit: https://reviewboard.mozilla.org/r/117810/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117810/

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8844313 [details]
Bug 1345005 - Ensure validation prefs are set for all tests that run a full sync.

https://reviewboard.mozilla.org/r/117810/#review119654

Sounds fine, assuming these tests still pass. I'm a little concerned it might lead to more intermittents for tests that don't actually care about validation, but I guess we can address those if/when they happen.

Comment 3

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 31f36d9caaad -d 00daf2c5342a: rebasing 379979:31f36d9caaad "Bug 1345005 - Ensure validation prefs are set for all tests that run a full sync. r=tcsc" (tip)
merging services/sync/tests/unit/head_appinfo.js
merging services/sync/tests/unit/head_helpers.js
merging services/sync/tests/unit/test_bookmark_engine.js
merging services/sync/tests/unit/test_fxa_node_reassignment.js
merging services/sync/tests/unit/test_hmac_error.js
merging services/sync/tests/unit/test_node_reassignment.js
merging services/sync/tests/unit/test_score_triggers.js
merging services/sync/tests/unit/test_telemetry.js
warning: conflicts while merging services/sync/tests/unit/head_appinfo.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging services/sync/tests/unit/head_helpers.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging services/sync/tests/unit/test_score_triggers.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 4

[Lina Butler [:lina]]

Comment on attachment 8844313 [details]
Bug 1345005 - Ensure validation prefs are set for all tests that run a full sync.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117810/diff/1-2/

Comment 5

[Lina Butler [:lina]]

Comment on attachment 8844313 [details]
Bug 1345005 - Ensure validation prefs are set for all tests that run a full sync.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117810/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88d9fad7a2d0
Ensure validation prefs are set for all tests that run a full sync. r=tcsc

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/88d9fad7a2d0

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f476aef8eb56

Comment 9

[Lina Butler [:lina]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f476aef8eb56