Use cached metadata images in highlights

RESOLVED FIXED

Status

()

Firefox for iOS
Home screen
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: fluffyemily, Assigned: fluffyemily)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios8.0+)

Details

(Whiteboard: [MobileAS])

Attachments

(1 attachment)

55 bytes, text/x-github-pull-request
farhan
: review+
Details | Review | Splinter Review
(Assignee)

Description

a year ago
We currently cache the images found in metadata in the SDWebImageManager shared cache when we create the metadata. This cached images is keyed by the URL relating to the image.

When we fetch the highlights from the database, we want to use the cached metadata image if it is present and default to the favicon if it is not.
(Assignee)

Updated

a year ago
Assignee: nobody → etoop
(Assignee)

Updated

a year ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

a year ago
Plan:

* Update Query in SQLLiteHistoryRecommendations:getHighlights() to join view_history_id_favicon with the metadata table to fetch metadata for all highlights
* Update Site object to contain a PageMetadata object
* Update SQLLiteHistory:basicHistoryColumnFactory to create PageMetadata object if metadata present and add to returned Site
* Update Highlights UI Code to check for presence of PageMetadata:MediaURL value. If present, this should be used as highlights image rather than favicon, otherwise favicon should be used
* Update TopSites provider name display code to fetch provider name from Site:PageMetadata rather than from a property directly in Site.
(Assignee)

Comment 2

a year ago
Created attachment 8844903 [details] [review]
Pull request
Attachment #8844903 - Flags: review?(sleroux)
Attachment #8844903 - Flags: review?(fpatel)
Comment on attachment 8844903 [details] [review]
Pull request

I didn't look too much into the SQL bits. But the rest of it looks good
Attachment #8844903 - Flags: review?(fpatel) → review+
(Assignee)

Updated

a year ago
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Comment on attachment 8844903 [details] [review]
Pull request

Left a comment about potential DB table creation issues.
Attachment #8844903 - Flags: review?(sleroux)
You need to log in before you can comment on or make changes to this bug.