Closed Bug 1345075 Opened 7 years ago Closed 7 years ago

Remove FX_SANITIZE_LOADED_FLASH and FX_SANITIZE_UNLOADED_FLASH

Categories

(Firefox :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: mak, Assigned: mak)

Details

Attachments

(1 file)

These probes are expiring, they gave us an idea of whether the long clearing times where somehow related to a loaded or unloaded flash plugin during sanitizations.

We measured that clearings taking more than 10 seconds are about 0.5% for an unloaded flash and 0.1% for a loaded one. For a very tiny percentage of cases taking more than 30s, this could have been one plausible cause of forced async shutdown crash.
The measurements were pretty much stable in the last 6 versions.

Considering the measurement is not bringing anything new to the table and the clear deprecation of Flash, these probes and their related code can be removed.
Comment on attachment 8844425 [details]
Bug 1345075 - Remove FX_SANITIZE_LOADED_FLASH and FX_SANITIZE_UNLOADED_FLASH.

https://reviewboard.mozilla.org/r/117900/#review119640
Attachment #8844425 - Flags: review?(felipc) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/bb3f996f37e7
Remove FX_SANITIZE_LOADED_FLASH and FX_SANITIZE_UNLOADED_FLASH. r=Felipe
https://hg.mozilla.org/mozilla-central/rev/bb3f996f37e7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: