1345104 - The find in page feature could tell the user if there are no hits for his search

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P5)

Description

[fabrizio :fabrizio]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170125094131

Steps to reproduce:

Suggestion:

When you search for some text using the "Find-in-Page" feature, the search box correctly indicates the number of hits when the text can be found.

However, when there are no hits, instead of showing nothing, there should be some feedback telling the user the text cannot be found. For instance, instead of showing the up and down arrows next to the search box (useless when there are no hits), there could be the string "Not found" instead.

Comment 1

[Luna Phipps-Costin]

It currently makes the field red and shows "Phrase not found." The arrows could disappear, but I don't think that's a good decision. Imagine that the page is still loading. Sometimes I will press the down arrow repeatedly until it finds a phrase (that I expect will load in).

So I think this is resolved or wontfix.

Tested on 57.0a1 and 52.3.0

Comment 2

[Luna Phipps-Costin]

Attachment: A picture of the current "no result" handling

Comment 3

[fabrizio :fabrizio]

The bug is for Firefox for Android, where this GUI feedback is not present.

Comment 4

[Luna Phipps-Costin]

Oops sorry; new to this.

Comment 5

[naskospasko]

I'll try to make this work. I noticed the same behavior. Desktop version puts color on the search box's backgnd, android version does not. You kinda don't know if there's a match or not when you just look at the screen.

Comment 7

[Sorina Florean [:sflorean]]

I was able to reproduce this with Xiaomi Mi4i (Android 5.0.2) on all branches. Marking the bug as New.

Comment 8

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 9

[mariahajmal]

I am an outreachy applicant. Can I work on this?

Comment 10

[Andrei Teslovan [:ateslovan]]

Attachment: Bug 1345104 - Show error when Find In Page returns no results; r?petru

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29103bace2ab
Show error when Find In Page returns no results; r=petru

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/29103bace2ab

Comment 13

[Sorina Florean [:sflorean]]

Verified as fixed on latest Nightly build.
Devices:

• Nokia 6(Android 7.1.1)
• Nexus 5 (Android 6.0.1)