1345107 - The Work Offline add-on breaks Firefox 52+ in multiple ways

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Artem S. Tashkinov]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170302120751

Steps to reproduce:

Upgraded from Firefox 51 to 52.


Actual results:

Many things broke:

- On every launch the bookmarks bar is empty, it doesn't contain any bookmarks (hiding/unhiding fixes it).
- Session store/restore doesn't work completely.
- The Firefox settings button doesn't work.


Expected results:

Nothing.

Comment 1

[Artem S. Tashkinov]

Just when I thought "The Addon Bar (Restored)" - works, no, it also breaks Firefox similarly.

There isn't a single statusbar add-on which works with Firefox 52.

Why have you broken Firefox 52 so much? :-(

Comment 2

[YF (Yang)]

Looks works for me, Status-4-Evar 2016.10.11.01 in Fx52.0 x64 with e10s on, on Win10.


This issue also happens with a clean profile? https://support.mozilla.org/kb/profile-manager-create-and-remove-firefox-profiles.

Comment 3

[Artem S. Tashkinov]

OK, here's to break Firefox 52 with a completely new profile:

1) Install Status-4-ever
2) Install Work Offline
3) Restart the browser
4) Right click the status bar -> Add the Work Offline icon
5) Go to settings, select "Show my windows and tabs from last time"
6) Show the bookmarks tab
7) Exit the browser
8) Launch the browser

Results:

* The Bookmarks bar is empty
* No previous tabs or windows are restored

Which means a _combination_ of these two add-ons are the real culprit.

I hope Mozilla developers will look into this issue and offer a fix/workaround/temporary solution.

Comment 4

[Artem S. Tashkinov]

People say the work offline extension alone is the culprit:

https://addons.mozilla.org/en-US/firefox/addon/work-offline/reviews/847341/

Comment 5

[YF (Yang)]

I got the https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=523d47a7f8f38c271a2d5cf4fb9cbdbad1036e3b&tochange=c6ccd71126ff514bfc44b53e2217562e29a0cc38 from mozregression...

Comment 6

[YF (Yang)]

STR:
1. Install the https://addons.mozilla.org/firefox/addon/work-offline/, restart to apply.
2. Customize to drag its icon to toolbar, restart.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Jorge, sounds like blocklisting may be in order?

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

This is a compatibility issue, so no block is required. I'll add a compatibility override.

Comment 9

[Jorge Villalobos [:jorgev] (he/him)]

Done.

Comment 10

[Artem S. Tashkinov]

Since like the add on has been brought down: https://addons.mozilla.org/firefox/addon/work-offline/

And when you search for it, the result brings back to the search page.