Closed
Bug 1345112
Opened 7 years ago
Closed 7 years ago
Fix invalid console.trace() calls in inspector front
Categories
(DevTools :: Inspector, enhancement, P3)
DevTools
Inspector
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jdescottes, Assigned: anejaalisha, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(4 files)
The inspector front contains two invalid calls to console.trace() : - http://searchfox.org/mozilla-central/rev/1bc7720a434af3c13b68b8d69f92078cae8890c4/devtools/shared/fronts/inspector.js#770 - http://searchfox.org/mozilla-central/rev/1bc7720a434af3c13b68b8d69f92078cae8890c4/devtools/shared/fronts/inspector.js#829 `console.trace()` does not take any argument (https://developer.mozilla.org/en-US/docs/Web/API/Console/trace). Therefore the strings passed to console.trace() in these 2 spots are never logged anywhere. The goal of this bug is to split the calls in order to first call `console.warn` with the string, and then `console.trace` without any argument. This should be a good first bug. You can have a look at https://developer.mozilla.org/en-US/docs/Tools/Contributing to get started!
Assignee | ||
Comment 1•7 years ago
|
||
Hi, Can I work on solving this bug? And if I can, can you provide me with some more details about it?:)
Flags: needinfo?(jdescottes)
Reporter | ||
Comment 2•7 years ago
|
||
Thanks! Assigning the bug to you. You should find some information to get started in my first comment. The basic idea is to modify the two calls to console.trace from: > console.trace("some message"); to > console.warn("some message"); > console.trace(); The only issue here is that I don't have a scenario to trigger this issue.
Assignee: nobody → anejaalisha
Status: NEW → ASSIGNED
Flags: needinfo?(jdescottes)
Assignee | ||
Comment 3•7 years ago
|
||
Assignee | ||
Comment 4•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Attachment #8845665 -
Attachment is patch: false
Attachment #8845665 -
Attachment mime type: text/plain → image/png
Assignee | ||
Comment 5•7 years ago
|
||
Hi, I have resolved the bug. But I am pretty confused how to push changes/get them reviewed as earlier I have worked on treeherder/bedrock codebase where we create Pull Requests. Attachments for your review:)
Reporter | ||
Updated•7 years ago
|
Attachment #8845664 -
Attachment is patch: false
Attachment #8845664 -
Attachment mime type: text/plain → image/png
Reporter | ||
Comment 6•7 years ago
|
||
The changes look ok, but you need to submit them as patch, screenshots won't do here :) If you are using Git, follow the instructions at https://developer.mozilla.org/en-US/docs/Tools/Contributing If you are using mercurial, this page might be more appropriate: https://wiki.mozilla.org/DevTools/Hacking I can help you if you are really stuck, but please give a shot to the documentation above and let me know which step you are blocked at.
Assignee | ||
Comment 7•7 years ago
|
||
I suppose I have created the patch following all instructions from here:https://developer.mozilla.org/en-US/docs/Tools/Contributing#Checking_in. But I am really stuck as in how to move forward. How to checkout the patch which I worked? I am also attaching the terminal screenshot. Thanks!
Flags: needinfo?(jdescottes)
Assignee | ||
Comment 8•7 years ago
|
||
Reporter | ||
Comment 9•7 years ago
|
||
According to your screenshot you should have a Bug1345112.patch on your filesystem. Can you please attach this file here?
Flags: needinfo?(jdescottes)
Assignee | ||
Comment 10•7 years ago
|
||
Attachment #8846277 -
Flags: review?(jdescottes)
Reporter | ||
Comment 11•7 years ago
|
||
Comment on attachment 8846277 [details] [diff] [review] Bug1345112.patch Review of attachment 8846277 [details] [diff] [review]: ----------------------------------------------------------------- The patch look good now :) Thanks for taking the time to go through this!
Attachment #8846277 -
Flags: review?(jdescottes) → review+
Reporter | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 12•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b2635d26a7b7 Fix invalid console.trace() calls in inspector front. r=jdescottes
Keywords: checkin-needed
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b2635d26a7b7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•