1345132 - test_claim.html is racy

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

It looks like test_claim.html has a bug where it does not actually wait for the claim() promise to resolve.  It does:

  return claimPromise.then(self.clients.matchAll().then(function(matched) {

Which executes the matchAll() immediately.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Fix races in test_claim.html mochitest. r=catalinb

Catalin, I think the promise handling in these workers is not quite right.  Right now its executing that second matchAll() immediately which causes it to race with the claim().

Comment 2

[Cătălin Badea (:catalinb)]

Comment on attachment 8844496 [details] [diff] [review]
Fix races in test_claim.html mochitest. r=catalinb

Review of attachment 8844496 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, it's definitely wrong. Thanks for spotting this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0d5e6f181da
Fix races in test_claim.html mochitest. r=catalinb

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a0d5e6f181da