Closed Bug 1345157 Opened 3 years ago Closed 3 years ago

Linux builds not running on-push on mozilla-beta

Categories

(Release Engineering :: General, defect)

defect
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
Tracking Status
firefox55 --- fixed

People

(Reporter: coop, Assigned: kmoir)

Details

Attachments

(2 files, 4 obsolete files)

11:04 <philor> huh, did we decide to just not run Linux debug on beta?
11:06 <Callek> philor: not an intentional decide aiui
11:06 <Callek> but quite possible we accidentally turned it off...
11:08 <philor> not running either opt or debug on-push builds or tests, only nightly builds and tests
11:09 <philor> so possibly whatever decided to do nightly builds on every push also decided to shut off on-push builds, rather too completely
11:10 <philor> and also ASan
Assignee: nobody → kmoir
Attached patch bug1345157.patch (obsolete) — Splinter Review
Attached file bug1345157task.diff (obsolete) —
This is the diff of the output of the taskgraph generation for target_tasks_method: mozilla_beta_tasks before and after the change

not sure if all platforms are included that are required. I looked at the current builds generated by a ffxbld push on m-b
Attachment #8844617 - Flags: review?(aki)
Comment on attachment 8844617 [details] [diff] [review]
bug1345157.patch

Let's not enable linux64 and linux32, since we're enabling linux64-nightly and linux-nightly below?
Attachment #8844617 - Flags: review?(aki) → review+
Attached patch bug1345157-2.patch (obsolete) — Splinter Review
If I don't enable linux and linux64 I don't get the associated debug builds in the new graph
Attachment #8844617 - Attachment is obsolete: true
Attachment #8844707 - Flags: review?(aki)
Attached file bug1345157task-2.diff (obsolete) —
Attachment #8844621 - Attachment is obsolete: true
Enabling linux and linux64 dep builds alongside the nightlies may be problematic for release promotion. Let's test on jamun?
:rail, do you think we'll have issues if we run ci linux{32,64} opt builds alongside the nightlies?
Flags: needinfo?(rail)
If the index routes are different, that's ok.

See the indexes we use in release promotion: https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/config.py#l2393
Flags: needinfo?(rail)
Landed a modified patch on jamun and the debug builds are appearing

https://treeherder.mozilla.org/#/jobs?repo=jamun&revision=237312e24959812726374ba187fb7f74ac12f2dd
Aki should I land this patch on m-b?
Flags: needinfo?(aki)
:kmoir, I have 2 concerns here that I wanted to jump on, then got distracted by fennec53b1 issues:

* I'm not sure we've doublechecked the routes: comment 8 looks like a conditional?
* We are currently filtering by platform only for this block, but we could potentially also filter out /opt for linux+linux64.  I'm not sure which attribute to check for this.

I would personally prefer to either have nightly or ci linux/linux64 builds.  If we have the latter only, we'll need to make them promotable, which means clobber/mozconfig/mhconfig/signing/?, and we'll need to make sure that doesn't break promotion.  If we have both, we'll have double the builds+tests for these.  If we're able to filter out the linux{,64}/opt ci builds, I think that's the best solution.  I'm hoping that's not too much harder, but I haven't had a moment to check.
Flags: needinfo?(aki)
Okay, I'll investigate and write new patches, thanks aki.
Attachment #8844707 - Attachment is obsolete: true
Attachment #8844707 - Flags: review?(aki)
Attached file bug1345157task-3.diff
Attachment #8844708 - Attachment is obsolete: true
Comment on attachment 8845043 [details] [diff] [review]
bug1345157-3.patch

The routes are different for opt vs nightly

opt routes
"routes": [
        "index.gecko.v2.jamun.latest.firefox.linux64-opt",
        "index.gecko.v2.jamun.pushdate.2017.03.08.20170308142522.firefox.linux64-opt",
        "index.gecko.v2.jamun.revision.237312e24959812726374ba187fb7f74ac12f2dd.firefox.linux64-opt",
        "tc-treeherder.v2.jamun.237312e24959812726374ba187fb7f74ac12f2dd.167",
        "tc-treeherder-stage.v2.jamun.237312e24959812726374ba187fb7f74ac12f2dd.167"
      ],

vs the ones for release promotion (signing-linux64-nightly/opt)
https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/config.py#l2393

 "provisionerId": "scriptworker-prov-v1",
      "routes": [
        "index.gecko.v2.jamun.signed-nightly.nightly.latest.firefox.linux64-opt",
        "index.gecko.v2.jamun.signed-nightly.nightly.2017.03.08.revision.237312e24959812726374ba187fb7f74ac12f2dd.firefox.linux64-opt",
        "index.gecko.v2.jamun.signed-nightly.nightly.2017.03.08.latest.firefox.linux64-opt",
        "index.gecko.v2.jamun.signed-nightly.nightly.revision.237312e24959812726374ba187fb7f74ac12f2dd.firefox.linux64-opt",
        "index.gecko.v2.jamun.signed-nightly.revision.237312e24959812726374ba187fb7f74ac12f2dd.firefox-l10n.linux64-opt.en-US",
        "index.gecko.v2.jamun.signed-nightly.pushdate.2017.03.08.20170308142522.firefox-l10n.linux64-opt.en-US",
        "index.gecko.v2.jamun.signed-nightly.latest.firefox-l10n.linux64-opt.en-US",
        "index.project.releng.funsize.level-2.jamun",
        "tc-treeherder.v2.jamun.237312e24959812726374ba187fb7f74ac12f2dd.167",
        "tc-treeherder-stage.v2.jamun.237312e24959812726374ba187fb7f74ac12f2dd.167"
      ],
Attachment #8845043 - Flags: review?(aki)
Comment on attachment 8845043 [details] [diff] [review]
bug1345157-3.patch

Awesome, thank you so much :kmoir!
Attachment #8845043 - Flags: review?(aki) → review+
Pushed by kmoir@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d3216cb7b59
Linux builds not running on-push on mozilla-beta r=aki DONTBUILD
Comment on attachment 8845043 [details] [diff] [review]
bug1345157-3.patch

landed on inbound, m-b, m-a and jamun
Attachment #8845043 - Flags: checked-in+
Pushed by kmoir@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9553aa67aaa8
Linux builds not running on-push on mozilla-beta r=aki DONTBUILD
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.