Resigning script doesn't update the AppIdentifierPrefix Info.plist property for extensions

RESOLVED FIXED

Status

()

Firefox for iOS
Build & Test
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: sleroux, Assigned: sleroux)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios7.0+)

Details

(Whiteboard: [MobileCore])

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Part of the resigning script involves updating values in each target's Info.plist file to use the new team and bundle identifiers. One particular custom property we added, AppIdentifierPrefix, was not being updated for any of the extensions as part of the resigning process. This property is critical in grabbing the correct handle to the keychain. The current issue with 7.0b1893 is that we are using the enterprise team ID as the keychain prefix when it needs to be the non-enterprise account.
(Assignee)

Comment 1

a year ago
Created attachment 8844541 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2498
Attachment #8844541 - Flags: review?(fpatel)
(Assignee)

Comment 2

a year ago
Note: I published a test internal beta build that was resigned (1945) and was able to verify Bug 1344608 and 1344607 on my device. If you're interested I can add you to the build for testing.
Attachment #8844541 - Flags: review?(fpatel) → review+
(Assignee)

Comment 3

a year ago
Removing 1344607 as it doesn't seem related. Thanks for the test :rnewman!
No longer blocks: 1344607
(Assignee)

Updated

a year ago
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.