Closed Bug 1345181 Opened 3 years ago Closed 3 years ago

Improve performance of html_quote()

Categories

(bugzilla.mozilla.org :: General, enhancement)

Production
enhancement
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: dylan, Assigned: dylan)

Details

Attachments

(1 file)

44 bytes, text/x-github-pull-request
Atoll
: review+
Details | Review
html_quote() is called a lot. For a big buglist, it might be called hundreds of thousands of times. 

It is called enough that the difference between an O(n) and O(n*5) is measurable -- about 1 second for a 5000-bug buglist vs. .300 second to the patch I'm going to attach to this.
Attached file pull request
Hey :atoll, I thought maybe you'd like to review something. :-)
Attachment #8844551 - Flags: review?(rsoderberg)
Attachment #8844551 - Flags: review?(rsoderberg) → review+
To git@github.com:mozilla-bteam/bmo.git
   9c26c0186..d1cf67fc2  master -> master
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Seeing more warnings in sentry, but it looks like this would have always produced warnings. I'll fix that in a new bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.