Improve performance of html_quote()

VERIFIED FIXED

Status

()

VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: dylan, Assigned: dylan)

Tracking

Production

Details

Attachments

(1 attachment)

html_quote() is called a lot. For a big buglist, it might be called hundreds of thousands of times. 

It is called enough that the difference between an O(n) and O(n*5) is measurable -- about 1 second for a 5000-bug buglist vs. .300 second to the patch I'm going to attach to this.
(Assignee)

Comment 1

2 years ago
Created attachment 8844551 [details] [review]
pull request

Hey :atoll, I thought maybe you'd like to review something. :-)
Attachment #8844551 - Flags: review?(rsoderberg)

Updated

2 years ago
Attachment #8844551 - Flags: review?(rsoderberg) → review+
(Assignee)

Comment 2

2 years ago
To git@github.com:mozilla-bteam/bmo.git
   9c26c0186..d1cf67fc2  master -> master
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

2 years ago
Seeing more warnings in sentry, but it looks like this would have always produced warnings. I'll fix that in a new bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.