Closed Bug 1345186 Opened 3 years ago Closed 3 years ago

Ignore unused-function warnings when building third-party libstagefright code

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file)

Noticed these build warnings today (which happen in both clang and gcc):
{
media/libstagefright/system/core/liblog/logprint.c:88:13: warning: 'filterinfo_free' defined but not used [-Wunused-function]

media/libstagefright/system/core/liblog/logprint.c:176:13: warning: 'dumpFilters' defined but not used [-Wunused-function]
}

We already ignore a bunch of build warnings in media/libstagefright/moz.build (e.g. from bug 1288390), since this is third-party code. Might as well ignore this one too.
Comment on attachment 8844554 [details]
Bug 1345186: Suppress -Wunused-function build warnings in third-party libstagefright C code.

https://reviewboard.mozilla.org/r/117934/#review119712

LGTM, as long as try is happy.
Attachment #8844554 - Flags: review?(mshal) → review+
Comment on attachment 8844554 [details]
Bug 1345186: Suppress -Wunused-function build warnings in third-party libstagefright C code.

https://reviewboard.mozilla.org/r/117934/#review119774

Thank you for this patch.

::: commit-message-517c5:1
(Diff revision 1)
> +Bug 1345186: Suppreess -Wunused-function build warnings in third-party libstagefright C code. r?mshal

'Suppreess' -> 'Suppress'
Oops, thanks for catching that!  I'll fix before landing.
TryServer is happy -- 1 red build for an unrelated issue, it seems:
 https://treeherder.mozilla.org/#/jobs?repo=try&revision=d09c690e00fa&selectedJob=82255587
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c3dae108363c
Suppress -Wunused-function build warnings in third-party libstagefright C code. r=mshal
https://hg.mozilla.org/mozilla-central/rev/c3dae108363c
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.