1345186 - Ignore unused-function warnings when building third-party libstagefright code

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Daniel Holbert [:dholbert]]

Noticed these build warnings today (which happen in both clang and gcc):
{
media/libstagefright/system/core/liblog/logprint.c:88:13: warning: 'filterinfo_free' defined but not used [-Wunused-function]

media/libstagefright/system/core/liblog/logprint.c:176:13: warning: 'dumpFilters' defined but not used [-Wunused-function]
}

We already ignore a bunch of build warnings in media/libstagefright/moz.build (e.g. from bug 1288390), since this is third-party code. Might as well ignore this one too.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1345186: Suppress -Wunused-function build warnings in third-party libstagefright C code.

Review commit: https://reviewboard.mozilla.org/r/117934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117934/

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8844554 [details]
Bug 1345186: Suppress -Wunused-function build warnings in third-party libstagefright C code.

https://reviewboard.mozilla.org/r/117934/#review119712

LGTM, as long as try is happy.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8844554 [details]
Bug 1345186: Suppress -Wunused-function build warnings in third-party libstagefright C code.

https://reviewboard.mozilla.org/r/117934/#review119774

Thank you for this patch.

::: commit-message-517c5:1
(Diff revision 1)
> +Bug 1345186: Suppreess -Wunused-function build warnings in third-party libstagefright C code. r?mshal

'Suppreess' -> 'Suppress'

Comment 4

[Daniel Holbert [:dholbert]]

Oops, thanks for catching that!  I'll fix before landing.

Comment 5

[Daniel Holbert [:dholbert]]

TryServer is happy -- 1 red build for an unrelated issue, it seems:
 https://treeherder.mozilla.org/#/jobs?repo=try&revision=d09c690e00fa&selectedJob=82255587

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 8844554 [details]
Bug 1345186: Suppress -Wunused-function build warnings in third-party libstagefright C code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117934/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3dae108363c
Suppress -Wunused-function build warnings in third-party libstagefright C code. r=mshal

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c3dae108363c