Closed Bug 1345243 Opened 3 years ago Closed 3 years ago

Remove support for building without DirectWrite

Categories

(Core :: Graphics: Text, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jrmuizel, Unassigned)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Now that we don't support XP it's reasonable for us to drop support for GDI fonts and rely solely on DirectWrite. We should start this process by removing support for building without DirectWrite.
Attachment #8844620 - Attachment is patch: true
Attachment #8844620 - Flags: review?(bas)
Comment on attachment 8844620 [details] [diff] [review]
Remove support for building without DirectWrite

Review of attachment 8844620 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/cairo/cairo/src/moz.build
@@ +37,5 @@
>      EXPORTS.cairo += [
>          'cairo-win32.h',
>      ]
> +    SOURCES += [
> +        'cairo-dwrite-font.cpp',

nit: Could you just move this into the SOURCES += below rather than leave this separate.
Attachment #8844620 - Flags: review?(bas) → review+
Priority: -- → P3
Whiteboard: [gfx-noted]
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/759381469dba
Remove support for building without DirectWrite. r=bas
https://hg.mozilla.org/mozilla-central/rev/759381469dba
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.