Closed Bug 1345247 Opened 7 years ago Closed 7 years ago

Devirtualize nsFrameSelection

Categories

(Core :: DOM: Selection, enhancement)

Product:
Core
Component:
DOM: Selection
Type:
enhancement
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

References

Details

Attachments

(1 file)

fix
11.03 KB, patch
dholbert
: review+
Details | Diff | Splinter Review 
This class is final and has no base classes so I think we can
make its remaining virtual methods non-virtual now.
Attached patch fix — — Splinter Review 
FYI, I'm removing the "class nsIScrollableFrame;" line because there's
an identical line a little later in this file.
Attachment #8844634 - Flags: review?(dholbert)
Comment on attachment 8844634 [details] [diff] [review]
fix

Review of attachment 8844634 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=me
Attachment #8844634 - Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5489cbc85d06
Devirtualize nsFrameSelection.  r=dholbert
https://hg.mozilla.org/mozilla-central/rev/5489cbc85d06
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: