Closed
Bug 1345247
Opened 9 years ago
Closed 9 years ago
Devirtualize nsFrameSelection
Categories
(Core :: DOM: Selection, enhancement)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
Attachments
(1 file)
|
11.03 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
This class is final and has no base classes so I think we can
make its remaining virtual methods non-virtual now.
|
Assignee | |
Comment 1•9 years ago
|
||
FYI, I'm removing the "class nsIScrollableFrame;" line because there's
an identical line a little later in this file.
Attachment #8844634 -
Flags: review?(dholbert)
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8844634 [details] [diff] [review]
fix
Review of attachment 8844634 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks! r=me
Attachment #8844634 -
Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5489cbc85d06
Devirtualize nsFrameSelection. r=dholbert
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•