1345277 - Crash uploading photos to Google photo

Status: RESOLVED FIXED

(Core :: DOM: Workers, enhancement)

Description

[Blake Kaplan (:mrbkap) (inactive)]

I was trying to upload some photos to [1] both by dragging and dropping image files and by clicking their upload link in the top right. The crash stacks can be found at [2]. What appears to be happening is that the Google Photos site uses a FileReader in a worker to do the upload. However, to do this, it uses the stream transport service (which is threadsafe) and my upload was the first attempted use of nsIStreamTransportService on any thread. In its constructor, it creates a thread pool and adds an observer to the observer service, which can only happen on the main thread.

It seems like the easiest fix might be to instantiate the service when we launch our first worker so that we're guaranteed to not create it off the main thread.

[1] https://photos.google.com/
[2] https://crash-stats.mozilla.com/report/index/c1f6637c-d674-4b4f-9212-0ccf92170307

Comment 1

[Andrea Marchesini [:baku]]

Attachment: fileReaderWorker.patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef7cda0c3484
Initialize nsIStreamTransportService before dispatching the first worker, r=ehsan

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ef7cda0c3484