Crash uploading photos to Google photo

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mrbkap, Assigned: baku)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

I was trying to upload some photos to [1] both by dragging and dropping image files and by clicking their upload link in the top right. The crash stacks can be found at [2]. What appears to be happening is that the Google Photos site uses a FileReader in a worker to do the upload. However, to do this, it uses the stream transport service (which is threadsafe) and my upload was the first attempted use of nsIStreamTransportService on any thread. In its constructor, it creates a thread pool and adds an observer to the observer service, which can only happen on the main thread.

It seems like the easiest fix might be to instantiate the service when we launch our first worker so that we're guaranteed to not create it off the main thread.

[1] https://photos.google.com/
[2] https://crash-stats.mozilla.com/report/index/c1f6637c-d674-4b4f-9212-0ccf92170307
Flags: needinfo?(amarchesini)
(Assignee)

Comment 1

2 years ago
Created attachment 8844962 [details] [diff] [review]
fileReaderWorker.patch
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8844962 - Flags: review?(ehsan)

Updated

2 years ago
Attachment #8844962 - Flags: review?(ehsan) → review+

Comment 2

2 years ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef7cda0c3484
Initialize nsIStreamTransportService before dispatching the first worker, r=ehsan

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ef7cda0c3484
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.