1345307 - Implement runtime-wide WeakCache

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement)

Description

[Steve Fink [:sfink] [:s:]]

It turns out that the problem with my gray mark bit JS test stuff was that I had a WeakCache containing things from multiple zones, and they ended up in different zone (sweep) groups. It seemed to me like a runtime-wide WeakCache would be useful, though I'm not sure how much could be ported to it (as opposed to manual sweep calls for the runtime.)

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Implement runtime-wide WeakCache

I'm not altogether clear whether this should be runtime-wide or ZoneGroup-wide. For my purposes, either would work. I looked a bit at wrapping the JitcodeGlobalTable in this, and that would be runtime-wide. But it's also not a particularly compelling use case.

Comment 2

[Jon Coppeard (:jonco)]

Comment on attachment 8844705 [details] [diff] [review]
Implement runtime-wide WeakCache

Review of attachment 8844705 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine.

It would be great if we could somehow assert that the per-zone weak cache only contained pointers in that zone but I don't see an easy way of doing that.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dd78a5e9eb0
Implement runtime-wide WeakCache, r=jonco

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9dd78a5e9eb0