Closed Bug 134535 Opened 23 years ago Closed 23 years ago

IE Favorites are imported only once; %20 favorites not updated

Categories

(SeaMonkey :: Bookmarks & History, defect)

x86
Windows 98
defect
Not set
major

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: schapel, Assigned: bugs)

References

Details

(Keywords: polish, regression)

Reproducible: Always

Steps to reproduce:
1. Add a favorite in IE.
2. Start Mozilla.

Expected Results: The new favorite appears in the Imported IE Favorites bookmark
folder.

Actual Results: The new favorite does not appear.

For the past few weeks, up to build 2002033009, my new IE favorites have not
been imported by Mozilla.
I have to confirm that bug. Even when using import dialog box from "manage
bookmarks", nothing is imported.

Build 2002033109
I see this.

To reproduce: close Mozilla. Open IE. Add a favorite. Close IE. Open Mozilla.
The new favorite is not to be found in Mozilla bookmarks at all, not even in
Imported IE Favorites.

Confirmed on Build ID: 2002032916 (0.9.9+) Windows 98. 

Blocks: 120814
Severity: normal → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
This new wave of "Imported IE favorites" problems started somewhere between
0.9.8 and 0.9.9. With the daily build which started this problem, I had two
"Imported IE favorites" submenus, one working correctly and one not.

If you remove user profile, Mozilla will import IE favorites when creating new
profile, but will not sort them correctly, and will not translate special
characters like "space" and leave them as "%20".
Nav triage team: nsbeta1-
Keywords: nsbeta1nsbeta1-
I think this bug should be fixed quickly, as it seems to be a regression from
0.9.8, and is very visible.  A new user who wants to have their IE favorites
imported would find the %20 garbage annoying, and we want people to want to use
Mozilla.

Build 2002040314 (0.9.9+) Windows XP Pro
*** Bug 138514 has been marked as a duplicate of this bug. ***
This is happening under 1.0RC1, and since it is very visible, I think it needs
to be fixed before the final release of 1.0
If you want this bug fixed for Mozilla 1.0, there are several things you can do:

1. Vote for this bug.

2. Go to bug 138000 and nominate this bug to be fixed for RC2. I already did
this, but another nomination together with a few more votes for this bug might
change the drivers' minds.

3. Did I mention vote for this bug?
I think this bug's Summary needs to be clarified, e.g. "Imported IE Favorites
are no longer imported at startup".

In the long term, where is the desired functionality of the IE Favorites
interoperability stated?  I've had to infer it from my experience using it, and
from the panoply of bug Summaries (and dupes).
*** Bug 138660 has been marked as a duplicate of this bug. ***
Could you also make it optional, so I don't have to import IE's favorites list
if I don't want so.

I don't have any favorites in IE and I hate deleting the empty "Imported IE
favorites" folder every time I reinstall Mozilla.
Is there any way to transfer the 27 dupes for bug 130079 to this bug?  If I
understand this bug correctly, all the continuing dupes are being caused by this
bug now.
Keywords: polish
Summary: Imported IE Favorites are no longer imported → After importing IE Favorites, new Favorites are not imported
This bug is different than 130079. Dupes for that bug are not dupes of this bug.
Votes cannot be transferred except by the people themselves.
I realize bug 130079 is different but, if I understand correctly, people are
still reporting it because of *this* bug.  So I'm suggesting that all new
"130079"-type bugs be dupe'd to this one, so that it's dupe-count is reflective
of the trouble it's causing.
The summary of this bug is misleading -or- this is not the bug I am voting for.
I want the percent 20 problem fixed. (This one, too, I guess.) Please let me
know if I need to vote for a different bug.
The %20 problem has been fixed. It is bug 130079. The problem is that IE
Favorites are not imported each time you start Mozilla anymore, so the %20 is
from a time when your Favorites were imported when the %20 problem existed. If
this problem is fixed, the next time you start Mozilla, your Favorites will be
imported again, and the %20 will go away.

The bottom line is that if someone is reporting that %20 appears in the Imported
IE Favorites bookmarks in a recent build, it is actually a symptom of this bug.
This is because it is this bug that keeps the %20 bookmarks around, even though
it is not this bug that caused them to appear in the first place.

I agree that from now on, bugs complaining about %20 should be dupes of this bug.
Old Summary: After importing IE Favorites, new Favorites are not imported
New Summary: IE Favorites are imported only once;  %20 favorites not updated
Summary: After importing IE Favorites, new Favorites are not imported → IE Favorites are imported only once; %20 favorites not updated
Good work on the %20 issue.
How about correct sorting order?
It worked on Mozilla 0.9.8.
> How about correct sorting order?

Could you submit a new bug on this, and explain what the correct sorting order
is? I agree there's some kind of problem, but I wouldn't know what the "Expected
Results" should be.
removing from RC2 list.
No longer blocks: 138000
WFM on build 2002-04-29 branch *if* I edit my PREFS.JS file.

Add the following to force it to always re-import:
 user_pref("browser.bookmarks.import_system_favorites", true);
Before editing it, you need to exit Mozilla, including the Quicklaunch.

Does this count as RESOLVED?  Or, does it still need to work when the user
hasn't manually edited the preferences file?!
If we had some UI to set this preference, I'd consider this to be a feature and
not a bug. Should we change the summary of this bug yet again to something like
"Add UI for optionally importing IE Favorites at startup"?
> How about correct sorting order?

I added bug 141137 for correcting the sorting order.
There's already bug 84272 re UI for import preference.  Feel free to vote for it!

We still need feedback about whether this PREFS.JS change "fixes" the problem. 
If it does, then it should help the programmers pinpoint the code that failed to
re-import automatically.
The change to prefs.js gives me two different Imported IE Favorites folders: one
imported when I created my profile and unsorted, and another created when I
start Mozilla and sorted with folders first. This is with Windows 98.
*** Bug 141138 has been marked as a duplicate of this bug. ***
Deleted the two Imported IE Favs (reason to why I have two is described in
thread of bug 141138) and edited prefs.js.  Didn't do anything for me at
first(no Imported IE at all), until I created a new profile, which had a partly
corrupt IE favs.  The %20 problem is solved, but [zh-tw] chars (non-western
charsets, maybe?) still don't come up correctly.  Unable to get Mozilla to
import any new IE bookmarks.  Have tried exiting Quicklaunch.  Using WinXP
traditional chinese.

One example of corrupt characters in bookmark:
http://www.pczone.com.tw/index.php
Never mind my last comment, I was just acting dumb.
After exiting quicklaunch and editing prefs.js, everything is good and well.
Except for one imported IE favs folder, it is in Big-5 coding, and in mozilla
appears as blank.  Everything else works well.
Regarding comment #21. The PREFS.JS change worked for me with 2002042908-TRUNK.

I don't think this is a resolution, but it seems to be a good "temp" patch.
When I set that preferences option in prefs.js in RC2, it creates a 2nd
"Imported IE Favorites" folder, in which the bookmarks do not work. If I click
on a link there, I get some information text about that bookmark in the main
window, but it does not load the page.
> If I click on a link there, I get some information text about that bookmark...

That's bug 143250.
Any ideas on a possible release note for this one?
*** Bug 143731 has been marked as a duplicate of this bug. ***
*** Bug 141122 has been marked as a duplicate of this bug. ***
*** Bug 144579 has been marked as a duplicate of this bug. ***
IE Favorites are no longer dynamic. UI for the import process has not yet been
added, there's another bug somewhere for that. If you want to use the dynamic
root, set this pref in your prefs.js file:
browser.bookmarks.import_system_favorites, note that this mode is no longer
``supported'' however. 
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → INVALID
So I guess the bugs I need to vote for are bug 59636 (UI for importing IE
favorites), bug 141137 (IE favorites appear in the wrong order), and bug 125075
(scroll arrows appear in bookmarks menus even when they're not needed).
*** Bug 146771 has been marked as a duplicate of this bug. ***
Ben,
Can you clarify what you mean by "no longer dynamic"?  Specifically:
- Are "Imported IE Favorites" supposed to be live links to IE?
- Are they supposed to be re-imported whenever Mozilla is restarted?
- Are they only imported one-time, i.e., when a new Mozilla profile is created?
- If they're now a one-time import, are they supposed to be "real" bookmarks
that can be manipulated in Bookmark Manager?

With the (now unsupported) PREFS option for "import_system_favorites", the
answer seemed to be Yes to the 2nd question.  Also, I've asked that something
about this be documented in the Release Notes (see bug 133795).
*** Bug 147353 has been marked as a duplicate of this bug. ***
*** Bug 147603 has been marked as a duplicate of this bug. ***
*** Bug 147859 has been marked as a duplicate of this bug. ***
*** Bug 153759 has been marked as a duplicate of this bug. ***
*** Bug 155698 has been marked as a duplicate of this bug. ***
*** Bug 157003 has been marked as a duplicate of this bug. ***
*** Bug 157706 has been marked as a duplicate of this bug. ***
Voters and duplicate reporters: Please go vote for bug 59636. Having that bug
fixed should solve the problems you're experiencing, but that bug is unlikely to
be fixed soon with only the 4 votes it currently has.
*** Bug 180520 has been marked as a duplicate of this bug. ***
No longer blocks: 120814
*** Bug 238568 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.