1345363 - Debugging information output when a test is timing out is truncated

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jean-Yves Avenard [:jya]]

When a test time out, debugging information is output on the console.

However, the text is truncated which makes it difficult to guess what has happened some times.

Example:
14:35:52     INFO - [1741] WARNING: Decoder=11f837400 channels=2 rate=22050 hasAudio=1 hasVideo=1 mPlayState=LOADING mdsm=11f815000
14:35:52     INFO - reader data:
14:35:52     INFO - audio decoder: apple CoreMedia decoder
14:35:52     INFO - audio frames decoded: 0
14:35:52     INFO - audio state: ni=0 no=0 wp:1 demuxr:0 demuxq:0 decoder:0 tt:-1.0 tths:-1 in:1 out:0 qs=1 pending:0 wfd:1 wfk:0 sid:6
14:35:52     INFO - video decoder: apple hardware VT decoder
14:35:52     INFO - hardware video decoding: enabled
14:35:52     INFO - video frames decoded: 22 (skipped:0)
14:35:52     INFO - video state: ni=0 no=0 wp:0 demuxr:0 demuxq:0 decoder:0 tt:-1.0 tths:-1 in:24 out:24

Here it's missing about 1/3rd of the full content.

My guess is that as it's output using NS_WARNING, the length allowed is actually limited and the content is truncated.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/d4adaabd6d2f88be0d0b151e022c06f6554909da/xpcom/base/nsDebugImpl.cpp#275
We should increase the buffer size to 1k or more.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1345363: Don't truncate debugging information.

NS_DebugBreak truncate all output to 500 characters.

Review commit: https://reviewboard.mozilla.org/r/118988/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118988/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8845846 [details]
Bug 1345363: Don't truncate debugging information.

https://reviewboard.mozilla.org/r/118988/#review121028

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80943e8c132b
Don't truncate debugging information. r=jwwang

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/80943e8c132b