1345371 - [Payment Request API] Support shippingOptionChange flow

Status: RESOLVED FIXED

(Core :: DOM: Web Payments, enhancement, P2)

Description

[Eden Chuang[:edenchuang]]

This bug is used for tracking the shippingOptionChange flow implementation, which is a part of Payment Request API.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

DOM: Device Interfaces is a better fit.

Comment 2

[Eden Chuang[:edenchuang]]

Fixed with the patch of bug 1318990. Set as resolved fixed.

Comment 3

[Chris Mills [:cmills]]

I've updated the browser support info on this page:

https://developer.mozilla.org/en-US/docs/Web/API/PaymentRequest/onshippingoptionchange

Comment 4

[Ben Tian (inactive)]

(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #3)
> I've updated the browser support info on this page:
> 
> https://developer.mozilla.org/en-US/docs/Web/API/PaymentRequest/
> onshippingoptionchange

Regarding the example:
1) In "// Empty array indicates rejection of the address" section, it's more informative to also set |PaymentDetailsUpdate.error| [1].
2) nit: extra indention since line 2

[1] https://w3c.github.io/browser-payment-api/#dom-paymentdetailsupdate-error

Comment 5

[Ben Tian (inactive)]

(In reply to Ben Tian [:btian] from comment #4)
> (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #3)
> > I've updated the browser support info on this page:
> > 
> > https://developer.mozilla.org/en-US/docs/Web/API/PaymentRequest/
> > onshippingoptionchange
> 
> Regarding the example:
> 1) In "// Empty array indicates rejection of the address" section, it's more
> informative to also set |PaymentDetailsUpdate.error| [1].
> 2) nit: extra indention since line 2

Update reference link as the repo just got renamed.

[1] https://w3c.github.io/payment-request/#dom-paymentdetailsupdate-error

Comment 6

[Chris Mills [:cmills]]

(In reply to Ben Tian [:btian] from comment #4)
> (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #3)
> > I've updated the browser support info on this page:
> > 
> > https://developer.mozilla.org/en-US/docs/Web/API/PaymentRequest/
> > onshippingoptionchange
> 
> Regarding the example:
> 1) In "// Empty array indicates rejection of the address" section, it's more
> informative to also set |PaymentDetailsUpdate.error| [1].

I've added a simple console.log statement - hope that's OK for now. I've not really got time to look into this in great detail currently.

> 2) nit: extra indention since line 2

Fixed.

> Update reference link as the repo just got renamed.
>
> [1] https://w3c.github.io/payment-request/#dom-paymentdetailsupdate-error

OK - I've updated the MDN JSON file that contains all the spec details, so that it points to the correct spec. It might take a little while to see it updated on the site.