[Payment Request API] Support shippingOptionChange flow

RESOLVED FIXED

Status

()

Core
DOM: Web Payments
P2
normal
RESOLVED FIXED
a year ago
9 months ago

People

(Reporter: edenchuang, Assigned: edenchuang)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [WP-MVP][M3])

(Assignee)

Description

a year ago
This bug is used for tracking the shippingOptionChange flow implementation, which is a part of Payment Request API.
(Assignee)

Updated

a year ago
Blocks: 1318987
(Assignee)

Updated

a year ago
Depends on: 1318990
DOM: Device Interfaces is a better fit.
Component: DOM → DOM: Device Interfaces
Priority: -- → P2
Component: DOM: Device Interfaces → DOM: Web Payments
Depends on: 1355385, 1355384
Depends on: 1355391, 1355392
No longer depends on: 1355384, 1355385
Whiteboard: [WP-MVP][M3]
(Assignee)

Comment 2

10 months ago
Fixed with the patch of bug 1318990. Set as resolved fixed.
Assignee: nobody → echuang
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
I've updated the browser support info on this page:

https://developer.mozilla.org/en-US/docs/Web/API/PaymentRequest/onshippingoptionchange
Keywords: dev-doc-complete

Comment 4

9 months ago
(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #3)
> I've updated the browser support info on this page:
> 
> https://developer.mozilla.org/en-US/docs/Web/API/PaymentRequest/
> onshippingoptionchange

Regarding the example:
1) In "// Empty array indicates rejection of the address" section, it's more informative to also set |PaymentDetailsUpdate.error| [1].
2) nit: extra indention since line 2

[1] https://w3c.github.io/browser-payment-api/#dom-paymentdetailsupdate-error

Comment 5

9 months ago
(In reply to Ben Tian [:btian] from comment #4)
> (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #3)
> > I've updated the browser support info on this page:
> > 
> > https://developer.mozilla.org/en-US/docs/Web/API/PaymentRequest/
> > onshippingoptionchange
> 
> Regarding the example:
> 1) In "// Empty array indicates rejection of the address" section, it's more
> informative to also set |PaymentDetailsUpdate.error| [1].
> 2) nit: extra indention since line 2

Update reference link as the repo just got renamed.

[1] https://w3c.github.io/payment-request/#dom-paymentdetailsupdate-error
(In reply to Ben Tian [:btian] from comment #4)
> (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #3)
> > I've updated the browser support info on this page:
> > 
> > https://developer.mozilla.org/en-US/docs/Web/API/PaymentRequest/
> > onshippingoptionchange
> 
> Regarding the example:
> 1) In "// Empty array indicates rejection of the address" section, it's more
> informative to also set |PaymentDetailsUpdate.error| [1].

I've added a simple console.log statement - hope that's OK for now. I've not really got time to look into this in great detail currently.

> 2) nit: extra indention since line 2

Fixed.

> Update reference link as the repo just got renamed.
>
> [1] https://w3c.github.io/payment-request/#dom-paymentdetailsupdate-error

OK - I've updated the MDN JSON file that contains all the spec details, so that it points to the correct spec. It might take a little while to see it updated on the site.
You need to log in before you can comment on or make changes to this bug.