Closed
Bug 1345377
Opened 6 years ago
Closed 6 years ago
Implement URLValueData::HasRef()
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: u459114, Assigned: u459114)
Details
Attachments
(1 file)
To reduce code in Layer::CalcDifference
Comment hidden (mozreview-request) |
Attachment #8844804 -
Flags: review?(cam)
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8844804 [details] Bug 1345377 - Implement URLValueData::HasRef. https://reviewboard.mozilla.org/r/118124/#review120312 r=me on the layout/style/ changes. ::: layout/svg/nsSVGEffects.cpp:1038 (Diff revision 1) > - return ResolveURLUsingLocalRef(aFrame, > - svgReset->mMask.mLayers[aIndex].mSourceURI); > + // mSourceURI can be used to address an SVG mask *only if* it contains a > + // fragment. > + const RefPtr<mozilla::css::URLValueData>& sourceURI = > + svgReset->mMask.mLayers[aIndex].mSourceURI; > + if (!sourceURI || !sourceURI->HasRef()) { > + return nullptr; > + } > + > + return ResolveURLUsingLocalRef(aFrame, sourceURI); Should this change be in a separate patch somewhere?
Attachment #8844804 -
Flags: review?(cam) → review+
Comment on attachment 8844804 [details] Bug 1345377 - Implement URLValueData::HasRef. https://reviewboard.mozilla.org/r/118124/#review120312 > Should this change be in a separate patch somewhere? I created this patch while working on bug 1301245. Yes, I can move these line back to that bug.
Comment hidden (mozreview-request) |
Pushed by cku@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/62a67b25472d Implement URLValueData::HasRef. r=heycam
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/62a67b25472d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•