1345377 - Implement URLValueData::HasRef()

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[u459114]

To reduce code in Layer::CalcDifference

Comment 1

[u459114]

Attachment: Bug 1345377 - Implement URLValueData::HasRef.

Improve code readability.

Review commit: https://reviewboard.mozilla.org/r/118124/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118124/

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8844804 [details]
Bug 1345377 - Implement URLValueData::HasRef.

https://reviewboard.mozilla.org/r/118124/#review120312

r=me on the layout/style/ changes.

::: layout/svg/nsSVGEffects.cpp:1038
(Diff revision 1)
> -  return ResolveURLUsingLocalRef(aFrame,
> -                                 svgReset->mMask.mLayers[aIndex].mSourceURI);
> +  // mSourceURI can be used to address an SVG mask *only if* it contains a
> +  // fragment.
> +  const RefPtr<mozilla::css::URLValueData>& sourceURI =
> +    svgReset->mMask.mLayers[aIndex].mSourceURI;
> +  if (!sourceURI || !sourceURI->HasRef()) {
> +    return nullptr;
> +  }
> +
> +  return ResolveURLUsingLocalRef(aFrame, sourceURI);

Should this change be in a separate patch somewhere?

Comment 3

[u459114]

Comment on attachment 8844804 [details]
Bug 1345377 - Implement URLValueData::HasRef.

https://reviewboard.mozilla.org/r/118124/#review120312

> Should this change be in a separate patch somewhere?

I created this patch while working on bug 1301245. Yes, I can move these line back to that bug.

Comment 4

[u459114]

Comment on attachment 8844804 [details]
Bug 1345377 - Implement URLValueData::HasRef.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/118124/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62a67b25472d
Implement URLValueData::HasRef. r=heycam

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/62a67b25472d