Implement URLValueData::HasRef()

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: u459114, Assigned: u459114)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
To reduce code in Layer::CalcDifference
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8844804 - Flags: review?(cam)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8844804 [details]
Bug 1345377 - Implement URLValueData::HasRef.

https://reviewboard.mozilla.org/r/118124/#review120312

r=me on the layout/style/ changes.

::: layout/svg/nsSVGEffects.cpp:1038
(Diff revision 1)
> -  return ResolveURLUsingLocalRef(aFrame,
> -                                 svgReset->mMask.mLayers[aIndex].mSourceURI);
> +  // mSourceURI can be used to address an SVG mask *only if* it contains a
> +  // fragment.
> +  const RefPtr<mozilla::css::URLValueData>& sourceURI =
> +    svgReset->mMask.mLayers[aIndex].mSourceURI;
> +  if (!sourceURI || !sourceURI->HasRef()) {
> +    return nullptr;
> +  }
> +
> +  return ResolveURLUsingLocalRef(aFrame, sourceURI);

Should this change be in a separate patch somewhere?
Attachment #8844804 - Flags: review?(cam) → review+
(Assignee)

Comment 3

2 years ago
mozreview-review-reply
Comment on attachment 8844804 [details]
Bug 1345377 - Implement URLValueData::HasRef.

https://reviewboard.mozilla.org/r/118124/#review120312

> Should this change be in a separate patch somewhere?

I created this patch while working on bug 1301245. Yes, I can move these line back to that bug.
Comment hidden (mozreview-request)

Comment 5

2 years ago
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62a67b25472d
Implement URLValueData::HasRef. r=heycam

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/62a67b25472d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.