Open Bug 1345466 Opened 3 years ago Updated 2 years ago

Regression Quick second clicking the site info and permissions panel icon causes panel to perform animation twice

Categories

(Firefox :: Site Identity, defect, P5)

52 Branch
defect

Tracking

()

Tracking Status
firefox53 --- wontfix
firefox54 --- wontfix

People

(Reporter: 684sigma, Unassigned)

References

Details

(Keywords: regression)

I have a problem with Firefox Beta 52. It doesn't happen in Firefox ESR 45.
Sometimes when I open panel with site info, I want to close it as fast as possible. For that purpose, I click on doorhanger icon again as fast as possible. Quite often the panel changes its state from "open" to "open" and runs the distracting animation. It's especially bad, because browser performs in-your-face action "open panel with site info" while I'm trying to close the panel. It didn't happen on Firefox ESR 45.
It happens unpredictably, however, I noticed one specific scenario when it happens

1. Open https://gauntface.github.io/simple-push-demo/
2. Click on doorhanger icon in location bar, then (after 0.5s) click it again

Result: after first click the panel with site info appears, after second click it disappears and appears again, with distracting animation
Expected: shouldn't perform this animation
I think this is an extreme case, the user cannot get the want information within 0.5 seconds, and you can close it by clicking somewhere else instead of clicking the icon again.
Severity: normal → minor
Status: UNCONFIRMED → NEW
Component: Untriaged → Notifications and Alerts
Ever confirmed: true
Product: Firefox → Toolkit
Summary: Regression Panel with site info and permissions randomly performs animation sometimes → Quick second clicking the site info and permissions panel icon may missed from animation execution
(In reply to YF (Yang) from comment #1)
> I think this is an extreme case, the user cannot get the want information
> within 0.5 seconds

I do not want that information, because I clicked there by mistake and want to close the useless panel


> and you can close it by clicking somewhere else instead
> of clicking the icon again.

Almost every popup menu in Firefox is closed by clicking on the same place. Clicking in other place may be dangerous, because it may trigger navigation in current tab or loading of background tab.
What do you suggest, spend some time every time I click on popup menus, looking for a safe place outside of popup to click there for closing the popup? Please respond (with specifying whether it's your own opinion or Mozilla's opinion). My opinion is that it's a constant time loss.
Flags: needinfo?(yfdyh000)
Summary: Quick second clicking the site info and permissions panel icon may missed from animation execution → Regression Quick second clicking the site info and permissions panel icon may missed from animation execution
(In reply to 684sigma from comment #2)
> (In reply to YF (Yang) from comment #1)
> > I think this is an extreme case, the user cannot get the want information
> > within 0.5 seconds
> 
> I do not want that information, because I clicked there by mistake and want
> to close the useless panel
> 
> 
> > and you can close it by clicking somewhere else instead
> > of clicking the icon again.
> 
> Almost every popup menu in Firefox is closed by clicking on the same place.
> Clicking in other place may be dangerous, because it may trigger navigation
> in current tab or loading of background tab.
> What do you suggest, spend some time every time I click on popup menus,
> looking for a safe place outside of popup to click there for closing the
> popup? Please respond (with specifying whether it's your own opinion or
> Mozilla's opinion). My opinion is that it's a constant time loss.

In my view, quick in-place clicks are more risky, pop-up may not be underneath but overrides or centered on it, and then it may have some options or buttons to be displayed and mistakenly clicked. although this does not apply to doorhanger notifications design.
Flags: needinfo?(yfdyh000)
(In reply to YF (Yang) from comment #3)
> (In reply to 684sigma from comment #2)
> > (In reply to YF (Yang) from comment #1)
> > > I think this is an extreme case, the user cannot get the want information
> > > within 0.5 seconds
> > 
> > I do not want that information, because I clicked there by mistake and want
> > to close the useless panel
> > 
> > 
> > > and you can close it by clicking somewhere else instead
> > > of clicking the icon again.
> > 
> > Almost every popup menu in Firefox is closed by clicking on the same place.
> > Clicking in other place may be dangerous, because it may trigger navigation
> > in current tab or loading of background tab.
> > What do you suggest, spend some time every time I click on popup menus,
> > looking for a safe place outside of popup to click there for closing the
> > popup? Please respond (with specifying whether it's your own opinion or
> > Mozilla's opinion). My opinion is that it's a constant time loss.
> 
> In my view, quick in-place clicks are more risky, pop-up may not be
> underneath but overrides or centered on it, and then it may have some
> options or buttons to be displayed and mistakenly clicked. although this
> does not apply to doorhanger notifications design.

What you've described doesn't apply to pop-ups in Firefox at all, at least I don't remember any, and that's why my finger memory tells me that the safest and fastest way to close pop-up is to click on the same place.
Anyway, thanks for marking it "NEW".
Mozregression-gui generated this regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=07d7ecbf77e3be59797f16234d357a02bb38ed8b&tochange=0766f63202b5fd05043163f0f47ba7d735d61e99
->
1327946 – Identity block is unaccessible: can't be focused by keyboard (a11y)
https://bugzilla.mozilla.org/show_bug.cgi?id=1327946
Blocks: 1327946
Severity: minor → normal
Has Regression Range: --- → yes
Has STR: --- → yes
Flags: needinfo?(jhofmann)
Keywords: regression
Summary: Regression Quick second clicking the site info and permissions panel icon may missed from animation execution → Regression Quick second clicking the site info and permissions panel icon causes panel to perform animation twice
Interesting, I'm not sure why that patch caused this behavior, but it would probably require some digging to find the true cause. Might even be a platform issue. I also agree with YF that this is really an edge case, so I don't think we'll look into this anytime soon.
Component: Notifications and Alerts → Site Identity and Permission Panels
Flags: needinfo?(jhofmann)
Priority: -- → P5
Product: Toolkit → Firefox
You need to log in before you can comment on or make changes to this bug.