1345482 - Regression Enter in inspector doesn't work sometimes

Status: NEW

(DevTools :: Inspector, defect, P3)

Description

[684sigma]

I have a problem with Firefox Beta 52. It doesn't happen in Firefox ESR 45.
Sometimes Enter doesn't work in inspector to edit text, so I have to doubleclick on text node.
It happens unpredictably, however, I noticed one specific scenario when it happens

1. Open https://www.w3schools.com/html/HTML5_video.asp
2. Inspect text "HTML5" in "HTML5 Tutorial" on the page
3. Press down arrow to select text node "Tutorial" in inspector, then Enter to edit text node

Result: Nothing happens it seems
Expected: Inspector should start editing the text node

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

I'm not sure it's really a bug, but yes the behaviour changed. What happens is that first enter focuses on the tag, second - put it in the edit mode. I think it is a little confusing because this is just a leaf text node. 

First enter is equivalent to a single mouse click on the text node. Second enter - the double click.

Focus state is redundant here because there's nothing to tab over (unlike typical tags). But it is also reasonable to have a consistent keyboard behaviour around all inspector tree nodes.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

I guess simple text nodes can be an exception.

Comment 3

[Liz Henry (:lizzard)]

Too late for a fix for 53, fix-optional for 54, minor carryover regression.