Open Bug 1345482 Opened 5 years ago Updated 3 years ago

Regression Enter in inspector doesn't work sometimes


(DevTools :: Inspector, defect, P3)

49 Branch


(firefox52 wontfix, firefox-esr52 fix-optional, firefox53 wontfix, firefox54 fix-optional, firefox55 wontfix, firefox56 wontfix, firefox57 wontfix)

Tracking Status
firefox52 --- wontfix
firefox-esr52 --- fix-optional
firefox53 --- wontfix
firefox54 --- fix-optional
firefox55 --- wontfix
firefox56 --- wontfix
firefox57 --- wontfix


(Reporter: 684sigma, Unassigned)



(Keywords: regression)

I have a problem with Firefox Beta 52. It doesn't happen in Firefox ESR 45.
Sometimes Enter doesn't work in inspector to edit text, so I have to doubleclick on text node.
It happens unpredictably, however, I noticed one specific scenario when it happens

1. Open
2. Inspect text "HTML5" in "HTML5 Tutorial" on the page
3. Press down arrow to select text node "Tutorial" in inspector, then Enter to edit text node

Result: Nothing happens it seems
Expected: Inspector should start editing the text node
Blocks: 1242694
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → Developer Tools: Inspector
Ever confirmed: true
Version: 52 Branch → 49 Branch
Flags: needinfo?(yzenevich)
Keywords: regression
Priority: -- → P3
I'm not sure it's really a bug, but yes the behaviour changed. What happens is that first enter focuses on the tag, second - put it in the edit mode. I think it is a little confusing because this is just a leaf text node. 

First enter is equivalent to a single mouse click on the text node. Second enter - the double click.

Focus state is redundant here because there's nothing to tab over (unlike typical tags). But it is also reasonable to have a consistent keyboard behaviour around all inspector tree nodes.
Flags: needinfo?(yzenevich)
I guess simple text nodes can be an exception.
Too late for a fix for 53, fix-optional for 54, minor carryover regression.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.