Open
Bug 1345495
(rdm-perms)
Opened 7 years ago
Updated 2 years ago
[meta] Broken permission notifications / doorhangers in RDM
Categories
(DevTools :: Responsive Design Mode, enhancement, P3)
Tracking
(Not tracked)
NEW
People
(Reporter: 684sigma, Unassigned)
References
(Depends on 2 open bugs)
Details
(Keywords: meta, Whiteboard: [rdm-v2])
Attachments
(1 file)
4.82 KB,
text/html
|
Details |
I have a problem with Firefox Beta 52. It doesn't happen in Firefox ESR 45. Sometimes Plugin indicator, and permissions like push/geolocation break when Responsive Design Mode is involved. It happens unpredictably and result may vary, however, I noticed one specific scenario when it happens 1. Open https://gauntface.github.io/simple-push-demo/ 2. Click "Enable Push Notifications" on the page 3. Open Responsive Design Mode Result: notification disappears Expected: should stay https://gauntface.github.io/simple-push-demo/ http://dagobah.net/flashswf/CatGotLost.swf http://html5demos.com/geo
Status: UNCONFIRMED → NEW
Has STR: --- → yes
Component: Untriaged → Developer Tools: Responsive Design Mode
Ever confirmed: true
Summary: Regression Plugin indicator, and permissions like push/geolocation break if Responsive Design Mode is involved sometimes → [Regression] Opened plugin indicator and permissions like push/geolocation be eliminate and break if Responsive Design Mode is involved
That's true only with the new RDM available with e10s.
Keywords: regression
Summary: [Regression] Opened plugin indicator and permissions like push/geolocation be eliminate and break if Responsive Design Mode is involved → [e10s] Opened plugin indicator and permissions like push/geolocation be eliminate and break if the new RDM is involved
Can you list out all the notifications where you've seen issues? It's important to be specific because each one may involve a different code path. In my own testing with RDM: * Push Notifications on https://gauntface.github.io/simple-push-demo/ currently fails with: "aWindow is null" from PrivateBrowsingUtils.jsm * Geolocation on https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation works * Plugin indicator I am less sure about, since I don't have Flash at the moment
Flags: needinfo?(684sigma)
Priority: -- → P2
Plugin indicator is broken too when you select "ask to activate" for Flash. With new RDM open, clicking on "Activate plugin" doesn't call the notification in the location bar to allow Flash. Notifications about sharing media devices (webcam/microphone) are broken too, eg https://meet.jit.si/TestFirefox
All notification I remember are broken in Nightly 2017-03-21: push notifications, geolocation you mentioned, plugin, "save password", camera/microphone permission, (i) button (see Bug 1345716). Please read the rest of comment. I have to clarify your question. The 1st bug (this bug) is: "buttons in site identity block become invisible after entering/exiting RDM" It seems that you referred to the 2nd bug: "some notifications appear normally if opened in RDM, but they don't work" There's also the 3rd bug: "some notifications don't even appear in RDM" What exactly were you asking? I answered about "1st bug". To give the full answer I'll need an Excel table or something. I don't know if 2nd/3rd bugs are considered something different from this bug, but I was going to file them. 1) Should I file 2nd and/or 3rd bugs separately or is it OK to have one bug saying "notifications are broken with RDM"? 2) You said each notification may involve different codepath. Does it mean that each bug from this set should be split into several bug reports, one for each notification? 3) A random man like me can't tell the exact set of broken notifications. I would assume that you (being a developer) have a web page that contains the list of all notifications with correct names and a way to trigger each of them. With such page, I could at least check every notification/button in site identity block and answer your question(s), and such page is especially necessary if all mentioned problems are indeed involve different code. Without it my answer is unreliable.
Flags: needinfo?(684sigma) → needinfo?(jryans)
DRM notification is removed too: https://storage.googleapis.com/shaka-demo-assets/_bugs/persistent-session-support/index.html
(In reply to 684sigma from comment #4) > All notification I remember are broken in Nightly 2017-03-21: push > notifications, geolocation you mentioned, plugin, "save password", > camera/microphone permission, (i) button (see Bug 1345716). Please read the > rest of comment. Okay, that's a good list to start with. > I have to clarify your question. > > The 1st bug (this bug) is: "buttons in site identity block become invisible > after entering/exiting RDM" > It seems that you referred to the 2nd bug: "some notifications appear > normally if opened in RDM, but they don't work" > There's also the 3rd bug: "some notifications don't even appear in RDM" > What exactly were you asking? I answered about "1st bug". To give the full > answer I'll need an Excel table or something. I agree it's confusing, there are several aspects to consider here. For type 1, where the notification appears, but opening RDM causes it to disappear, I would consider that a very low priority bug, assuming it's possible to still access the notification somehow. For type 2 and 3, where the notification is either non-functional or doesn't appear when inside RDM, I would consider those more important than type 1, since it becomes impossible to proceed. > I don't know if 2nd/3rd bugs are considered something different from this > bug, but I was going to file them. > 1) Should I file 2nd and/or 3rd bugs separately or is it OK to have one bug > saying "notifications are broken with RDM"? I think I'll convert this bug into a meta bug for tracking notification issues in RDM. Then we can file more specific bugs and set them to block this meta bug. > 2) You said each notification may involve different codepath. Does it mean > that each bug from this set should be split into several bug reports, one > for each notification? Yes, I think a separate bug per notification type is the best way forward. There are some existing bugs for geolocation (bug 1278763) and WebRTC (bug 1297040). I would suggest focusing on the type 2 & 3 issues. > 3) A random man like me can't tell the exact set of broken notifications. I > would assume that you (being a developer) have a web page that contains the > list of all notifications with correct names and a way to trigger each of > them. With such page, I could at least check every notification/button in > site identity block and answer your question(s), and such page is especially > necessary if all mentioned problems are indeed involve different code. > Without it my answer is unreliable. I agree it would be nice to exhaustively check every possible notification type in RDM for completeness. I am not aware of a centralized list at the moment, so for now we may need to just file issues as we encounter them.
Flags: needinfo?(jryans)
Keywords: regression → meta
Summary: [e10s] Opened plugin indicator and permissions like push/geolocation be eliminate and break if the new RDM is involved → [meta] Broken permission notifications / doorhangers in RDM
Priority: P2 → P3
Alias: rdm-perms
Depends on: 1349796
Whiteboard: [rdm-v2]
"(error)" means that table cell also contains html comment with full text of error in console.
Updated•6 years ago
|
Product: Firefox → DevTools
Comment 8•5 years ago
|
||
ni? Martin to consider this for the planned RDM quality work.
Flags: needinfo?(mbalfanz)
Updated•4 years ago
|
Flags: needinfo?(mbalfanz)
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•