Closed Bug 1345506 Opened 7 years ago Closed 7 years ago

add BUG_COMPONENT to uriloader/* files

Categories

(Firefox :: File Handling, enhancement)

53 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file)

this directory is hard to figure out where it belongs.  there are 3 subdirs:
base/
exthandler/ (with tests and platform specific code)
prefetch/ (core::Networking: Cache)

I see many bugs that touched these files in networking, document navigation, xpcom, and file handling.  Predominately these are related to File Handling, although about half of the bugs seem to be "Core Graveyard::File Handling".

I decided to look at the tests since this is where we attach some value and the tests are almost all related to Core Graveyard::File Handling.
:blassey- I see many ipc related changes here as well as old maemo stuff- possibly you would have some ideas about what bugzilla component(s) we should map these files to?  Is there code we don't need anymore?  Knowing the tests are really old and in a graveyard, I suspect they are depreciating in usefulness, likewise with exthandler/gonk/* files.
Flags: needinfo?(blassey.bugs)
Blocks: 1328351
We certainly still use this code, though we could get rid of old platforms like maemo. Firefox/File handling seems like as good a place for the bugs to live as any.
Flags: needinfo?(blassey.bugs)
:paolo, most of this is File Handling code, if you have other thoughts or questions, please do ask, I am happy to change anything.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8845518 - Flags: review?(paolo.mozmail)
Comment on attachment 8845518 [details] [diff] [review]
add BUG_COMPONENT to uriloader/*

Some files in "uriloader/base" like nsIWebProgress.idl and friends might be related to networking core components, but others are File Handling interfaces.

The "exthandler" subfolder is indeed File Handling.
Attachment #8845518 - Flags: review?(paolo.mozmail) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/500a6512bcd5
add BUG_COMPONENT to uriloader/* files. r=paolo
https://hg.mozilla.org/mozilla-central/rev/500a6512bcd5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: