Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Add a message on the old RDM that tells people how to switch to the new RDM

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Responsive Design Mode
P1
normal
VERIFIED FIXED
4 months ago
23 days ago

People

(Reporter: pbro, Assigned: jryans)

Tracking

(Blocks: 1 bug, {dev-doc-needed, ux-discovery})

unspecified
Firefox 55
dev-doc-needed, ux-discovery
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
I've heard several times people reporting that they didn't find the network throttling tool, or that the UI in RDM looked different.
It's almost always a case of the user having e10s off and therefore not having the new RDM enabled.

It seems like these users would benefit from having a message displayed in the old RDM telling them how to switch to the new new one.

I don't know what the plan is to get rid of the old one entirely, but it seems to me that as long as non-e10s is supported, we'll have this problem.

I would suggest:

- adding some doc about this here: https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode
- and here: https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode_(before_Firefox_52)
- and adding a notification banner on the old RDM that refers to this doc, or something along those lines.
(Reporter)

Comment 1

4 months ago
Adding dev-doc-needed for the doc changes proposed in comment 0, if people agree that that's a good idea.
Ryan, what do you think?

For info, the most recent thread where this was mentioned: https://twitter.com/raymondcamden/status/839152448052789249
Flags: needinfo?(jryans)
Keywords: dev-doc-needed
(Assignee)

Comment 2

4 months ago
Thanks for filing, it's definitely been more confusing than I had hoped...

I went ahead and updated the two MDN pages with my own version of the problem, just so there's something on the page right now.  I'll leave the dev-doc-needed here, as MDN team might have better wording or articles to link to about this.

I'll take a look at adding a notification banner to old RDM.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Flags: needinfo?(jryans)
Priority: -- → P1
(Assignee)

Updated

4 months ago
Duplicate of this bug: 1345592
(Assignee)

Updated

4 months ago
Keywords: ux-discovery
(Assignee)

Updated

4 months ago
Blocks: 1345198
(Assignee)

Comment 4

4 months ago
I've added the various reports of people being confused by new RDM disappearing because of e10s disabled as blockers here.
(Assignee)

Updated

4 months ago
Depends on: 1349009

Updated

4 months ago
Duplicate of this bug: 1350206
Comment hidden (mozreview-request)
(Assignee)

Comment 7

3 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a68a1d94a8c311b440c6ae03829e22a3c54d6e24

Comment 8

3 months ago
mozreview-review
Comment on attachment 8859344 [details]
Bug 1345515 - Add notifications advertising new RDM.

https://reviewboard.mozilla.org/r/131380/#review134404

May be we should remove the notifications on RDM exit?
If you happen to toggle RDM on/off you will stack multiple notifications.

Do we happen to receive bug report from developers on Release or Beta?
As this patch doesn't improve the story there...

::: devtools/client/locales/en-US/responsiveUI.properties:74
(Diff revision 1)
> +
> +# LOCALIZATION NOTE (responsiveUI.newVersionUserDisabled): notification that appears
> +# when old RDM is displayed because the user has disabled new RDM.
> +responsiveUI.newVersionUserDisabled=A new version of Responsive Design Mode is available, but it appears to be disabled.  Please enable it and provide feedback, as this version will be removed.
> +# LOCALIZATION NOTE (responsiveUI.newVersionE10sDisabled): notification that appears
> +# when old RDM is dispalyed because e10s is disabled.

s/dispalyed/displayed/
Attachment #8859344 - Flags: review?(poirot.alex) → review+
(Assignee)

Comment 9

3 months ago
mozreview-review-reply
Comment on attachment 8859344 [details]
Bug 1345515 - Add notifications advertising new RDM.

https://reviewboard.mozilla.org/r/131380/#review134404

Ah, good catch, I'll update to remove the notification on close.

Yes, we've gotten reports from all channels I believe...  I think we'll just have to ride out the wave for now, since I can't easily uplift this (because of strings).

> s/dispalyed/displayed/

Thanks, fixed.
Comment hidden (mozreview-request)

Comment 11

3 months ago
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ef655e427521
Add notifications advertising new RDM. r=ochameau

Comment 12

3 months ago
sorry had to back this out for devtool test failures at responsivedesign.jsm like https://hg.mozilla.org/integration/autoland/rev/ef655e42752199b07ee40fc26ed9e650b989bd71
Flags: needinfo?(jryans)

Comment 13

3 months ago
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/182ed00b19e3
Backed out changeset ef655e427521 for devtool test failures at responsivedesign.jsm

Comment 14

3 months ago
mozreview-review
Comment on attachment 8859344 [details]
Bug 1345515 - Add notifications advertising new RDM.

https://reviewboard.mozilla.org/r/131380/#review134794

::: devtools/client/locales/en-US/responsiveUI.properties:72
(Diff revision 2)
>  responsiveUI.dontShowReloadNotification=Never show again
>  responsiveUI.dontShowReloadNotification_accesskey=N
> +
> +# LOCALIZATION NOTE (responsiveUI.newVersionUserDisabled): notification that appears
> +# when old RDM is displayed because the user has disabled new RDM.
> +responsiveUI.newVersionUserDisabled=A new version of Responsive Design Mode is available, but it appears to be disabled.  Please enable it and provide feedback, as this version will be removed.

You should really not have double spaces after a period, that's not the style used in Firefox.

Same for the other strings.
(Assignee)

Comment 15

3 months ago
mozreview-review-reply
Comment on attachment 8859344 [details]
Bug 1345515 - Add notifications advertising new RDM.

https://reviewboard.mozilla.org/r/131380/#review134794

> You should really not have double spaces after a period, that's not the style used in Firefox.
> 
> Same for the other strings.

Okay, I can change it...  Can we document this somewhere on the best practices[1]?  Double space after a period is a (fairly) common style when writing in a monospaced font, like in a code editor.

Since HTML trims whitespace to a single space, it will display the same in the UI either way.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices
Comment hidden (mozreview-request)
(Assignee)

Comment 17

3 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6869be9d00633c9f55e64728229f460b960b42aa
Flags: needinfo?(jryans)

Comment 18

3 months ago
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/00401ba00247
Add notifications advertising new RDM. r=ochameau

Comment 19

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/00401ba00247
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #15)
> Okay, I can change it...  Can we document this somewhere on the best
> practices[1]?  Double space after a period is a (fairly) common style when
> writing in a monospaced font, like in a code editor.

That's a copy rule, not localization. 

Michelle, I think I've lost track: were the copy guidelines for Firefox published? I don't remember if there was anything about punctuation.
Flags: needinfo?(mheubusch)

Comment 21

2 months ago
(In reply to Francesco Lodolo [:flod] from comment #20)
> (In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #15)
> > Okay, I can change it...  Can we document this somewhere on the best
> > practices[1]?  Double space after a period is a (fairly) common style when
> > writing in a monospaced font, like in a code editor.
> 
> That's a copy rule, not localization. 
> 
> Michelle, I think I've lost track: were the copy guidelines for Firefox
> published? I don't remember if there was anything about punctuation.

We do cover punctuation in the style guide but I hadn't considered spacing after a period - I had no idea double spacing after a period still persisted as a practice anywhere.  Thanks for the heads up - I will add a change request to update the guidelines posted here: https://bwinton.github.io/DesignSystem/copy-rules.html#punctuation
Flags: needinfo?(mheubusch)
I have reproduced this bug according to (2017-03-08)

Fixing bug is verified on latest Nightly-- Build ID :(20170614030206), 
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:56.0) Gecko/20100101 Firefox/56.0

Tested OS-- Windows7 32bit
QA Whiteboard: [bugday-20170614]
The notification bar added here doesn't appear for release or beta, which seems like an oversight.  I'll use bug 1373223 to address this.
Status: RESOLVED → VERIFIED
(Assignee)

Updated

23 days ago
Blocks: 1373223
You need to log in before you can comment on or make changes to this bug.