Closed Bug 1345530 Opened 3 years ago Closed 3 years ago

add BUG_COMPONENT to other-licenses/* files

Categories

(Core :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file, 1 obsolete file)

we have a series of 3rd party tools that were added for specific needs in-tree.
here is what components I found based on when these files were added:

$ ./mach file-info bugzilla-component other-licenses/**
Core :: Disability Access APIs
  other-licenses/atk-1.0
  other-licenses/ia2
Core :: Dom: IndexedDB
  other-licenses/snappy
Core :: General
  other-licenses/README
  other-licenses/moz.build
Core :: Graphics
  other-licenses/skia-npapi
Core :: JavaScript Engine
  other-licenses/ply
Core :: XPCOM
  other-licenses/bsdiff
Firefox :: Installer
  other-licenses/7zstub
Toolkit :: NSIS Installer
  other-licenses/nsis

asking tbsaunde for the a11y tools, mhowell for installer tools and overholt for the other tools.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8844983 - Flags: review?(overholt)
Attachment #8844983 - Flags: review?(mhowell)
Attachment #8844983 - Flags: a11y-review?(tbsaunde+mozbugs)
helps if i |hg add other-licenses/moz.build| which I added to annotate this
Attachment #8844983 - Attachment is obsolete: true
Attachment #8844983 - Flags: review?(overholt)
Attachment #8844983 - Flags: review?(mhowell)
Attachment #8844983 - Flags: a11y-review?(tbsaunde+mozbugs)
Attachment #8844984 - Flags: review?(tbsaunde+mozbugs)
Attachment #8844984 - Flags: review?(overholt)
Attachment #8844984 - Flags: review?(mhowell)
Attachment #8844984 - Flags: a11y-review?
Comment on attachment 8844984 [details] [diff] [review]
add BUG_COMPONENT to other-licenses/*

Review of attachment 8844984 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for adding these. I do have a slight preference for just using Firefox :: Installer for both the 7zstub and nsis directories. It's immaterial because I'm the one triaging both components, but the distinction between them isn't very useful and I'd like to consolidate them someday.
Attachment #8844984 - Flags: review?(mhowell) → review+
ok, I will move both to Firefox::Installer :)
Attachment #8844984 - Flags: a11y-review?
Attachment #8844984 - Flags: review?(tbsaunde+mozbugs) → review+
Comment on attachment 8844984 [details] [diff] [review]
add BUG_COMPONENT to other-licenses/*

Review of attachment 8844984 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, I profusely apologize for the delay here, Joel!

::: other-licenses/moz.build
@@ +28,5 @@
> +with Files('skia-npapi/**'):
> +    BUG_COMPONENT = ('Core', 'Graphics')
> +
> +with Files('snappy/**'):
> +    BUG_COMPONENT = ('Core', 'Dom: IndexedDB')

Nathan, should we have bugs snappy in filed under XPCOM?
Attachment #8844984 - Flags: review?(nfroyd)
Attachment #8844984 - Flags: review?(overholt) → review+
Comment on attachment 8844984 [details] [diff] [review]
add BUG_COMPONENT to other-licenses/*

Review of attachment 8844984 [details] [diff] [review]:
-----------------------------------------------------------------

Associating snappy-related things with XPCOM is probably reasonable.
Attachment #8844984 - Flags: review?(nfroyd) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b69eb63617e2
add BUG_COMPONENT to other-licenses/* files. r=tbsaunde, mhowell, overholt
https://hg.mozilla.org/mozilla-central/rev/b69eb63617e2
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.