1345530 - add BUG_COMPONENT to other-licenses/* files

Status: RESOLVED FIXED

(Core :: General, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

we have a series of 3rd party tools that were added for specific needs in-tree.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add BUG_COMPONENT to other-licenses/*

here is what components I found based on when these files were added:

$ ./mach file-info bugzilla-component other-licenses/**
Core :: Disability Access APIs
  other-licenses/atk-1.0
  other-licenses/ia2
Core :: Dom: IndexedDB
  other-licenses/snappy
Core :: General
  other-licenses/README
  other-licenses/moz.build
Core :: Graphics
  other-licenses/skia-npapi
Core :: JavaScript Engine
  other-licenses/ply
Core :: XPCOM
  other-licenses/bsdiff
Firefox :: Installer
  other-licenses/7zstub
Toolkit :: NSIS Installer
  other-licenses/nsis

asking tbsaunde for the a11y tools, mhowell for installer tools and overholt for the other tools.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add BUG_COMPONENT to other-licenses/*

helps if i |hg add other-licenses/moz.build| which I added to annotate this

Comment 3

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 8844984 [details] [diff] [review]
add BUG_COMPONENT to other-licenses/*

Review of attachment 8844984 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for adding these. I do have a slight preference for just using Firefox :: Installer for both the 7zstub and nsis directories. It's immaterial because I'm the one triaging both components, but the distinction between them isn't very useful and I'd like to consolidate them someday.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

ok, I will move both to Firefox::Installer :)

Comment 5

[Andrew Overholt [:overholt]]

Comment on attachment 8844984 [details] [diff] [review]
add BUG_COMPONENT to other-licenses/*

Review of attachment 8844984 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, I profusely apologize for the delay here, Joel!

::: other-licenses/moz.build
@@ +28,5 @@
> +with Files('skia-npapi/**'):
> +    BUG_COMPONENT = ('Core', 'Graphics')
> +
> +with Files('snappy/**'):
> +    BUG_COMPONENT = ('Core', 'Dom: IndexedDB')

Nathan, should we have bugs snappy in filed under XPCOM?

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8844984 [details] [diff] [review]
add BUG_COMPONENT to other-licenses/*

Review of attachment 8844984 [details] [diff] [review]:
-----------------------------------------------------------------

Associating snappy-related things with XPCOM is probably reasonable.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b69eb63617e2
add BUG_COMPONENT to other-licenses/* files. r=tbsaunde, mhowell, overholt

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b69eb63617e2