Closed
Bug 1345552
Opened 7 years ago
Closed 7 years ago
Disable Windows a11y+e10s in 54
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
(Whiteboard: aes+)
Attachments
(3 files)
3.86 KB,
patch
|
bugzilla
:
review+
jcristau
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
2.35 KB,
patch
|
bugzilla
:
review+
|
Details | Diff | Splinter Review |
1.16 KB,
patch
|
bugzilla
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1333250 +++ +++ This bug was initially created as a clone of Bug #1325690 +++ Let's disable a11y+e10s by default in Aurora 54.
Assignee | ||
Updated•7 years ago
|
Version: 52 Branch → 54 Branch
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=953b9e3bc3d6
Updated•7 years ago
|
Whiteboard: aes+
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8845079 -
Flags: review+
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8845080 -
Flags: review+
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8845081 -
Flags: review+
Assignee | ||
Comment 5•7 years ago
|
||
(These are the same patches as bug 1333250, but rebased to 54 Aurora)
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8845079 [details] [diff] [review] Part 1: Restore a11y+e10s checks Approval Request Comment [Feature/Bug causing the regression]: Windows a11y on e10s [User impact if declined]: Instability; new target version for this feature is 55 [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: No - it is a direct uplift to Aurora [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: All patches in this bug [Is the change risky?]: No [Why is the change risky/not risky?]: This change has already been made in 52 and 53. [String changes made/needed]: None
Attachment #8845079 -
Flags: approval-mozilla-aurora?
Comment 7•7 years ago
|
||
Comment on attachment 8845079 [details] [diff] [review] Part 1: Restore a11y+e10s checks no e10s with a11y in aurora54. Thanks Aaron.
Attachment #8845079 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•7 years ago
|
status-firefox54:
--- → affected
tracking-firefox54:
--- → +
Comment 8•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/da07ecdff44f https://hg.mozilla.org/releases/mozilla-aurora/rev/8c3d4d8fbb32 https://hg.mozilla.org/releases/mozilla-aurora/rev/de1f4aa0d12e
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 9•7 years ago
|
||
And a follow-up to re-disable the e10s a11y browser-chrome tests since they were permafailing (unsurprisingly, I guess). https://hg.mozilla.org/releases/mozilla-aurora/rev/be7a2a07bda7 Yura, aklotz wanted me to check with you to confirm that there was no other follow-up needed with respect to tests here.
Flags: needinfo?(yzenevich)
Comment 10•7 years ago
|
||
Only 1 test seems to be failing which feels like a regression. These tests seem to be passing on nightly, which is not much different from aurora that was branched this week. I will try to run these locally to see if I can get to the root cause.
You need to log in
before you can comment on or make changes to this bug.
Description
•