Closed Bug 1345553 Opened 3 years ago Closed 3 years ago

Menu bar has incorrect color on Windows 10

Categories

(Thunderbird :: Theme, defect)

54 Branch
Unspecified
Windows 10
defect
Not set

Tracking

(thunderbird54 fixed, thunderbird55 fixed)

RESOLVED FIXED
Thunderbird 55.0
Tracking Status
thunderbird54 --- fixed
thunderbird55 --- fixed

People

(Reporter: ssitter, Assigned: Paenglab)

Details

Attachments

(2 files)

Attached image screenshot
My Windows 10 Thunderbird Aurora build got upgraded from 53.0a2 to 54.0a2 today. 

In the new build the menu bar is colored with background color instead of tab color, see attached screenshot. Therefore the UI doesn't look as good as in previous builds.

Works in 53.0a2 (20170306004002)
Fails in 54.0a2 (20170308004024)
Attached patch Bug1345553.patchSplinter Review
Regression from bug 1343983.

Jörg, this is a very simple CSS patch. You have Windows 7 and the same issue (when you disable your userChrome.css). You are also the perfect person to review this.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8845038 - Flags: review?(jorgk)
(In reply to Richard Marti (:Paenglab) from comment #1)
> Jörg, this is a very simple CSS patch. You have Windows 7 and the same issue
> (when you disable your userChrome.css). You are also the perfect person to
> review this.
On Windows 7, the menu bar is on top of the tabs even without userChrome.css (which you kindly supplied to me for Windows 10, and I'm impressed that you remember that).

With and without the patch, the colour is not white but grey, as it should be, using the Default theme.
Can you switch to Aero? Then the menubar is below the tabs.
Comment on attachment 8845038 [details] [diff] [review]
Bug1345553.patch

Aero, yuk, cough :-(
But the patch works ;-)
Attachment #8845038 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/cf8547515fcdf4a8f5c314f6e8ea657e7fe7323e

Note: Pushed this after the previous build failed with inconsistent results and doing a clobber. Fingers crossed.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
Version: 53 Branch → 54 Branch
You need to log in before you can comment on or make changes to this bug.