Closed
Bug 1345564
Opened 5 years ago
Closed 5 years ago
Remove PVRManager::GetImmediateSensorState sync IPC call and related code
Categories
(Core :: WebVR, enhancement)
Core
WebVR
Tracking
()
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: kip, Assigned: kip)
References
Details
Attachments
(1 file)
Due to earlier refactoring and changes in the WebVR API, we can remove this code and it's related sync IPC call.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•5 years ago
|
Attachment #8845042 -
Flags: review?(ehsan)
Attachment #8845042 -
Flags: review?(dmu)
Comment 2•5 years ago
|
||
mozreview-review |
Comment on attachment 8845042 [details] Bug 1345564 - Reduce sync IPC calls used by WebVR https://reviewboard.mozilla.org/r/118268/#review120128 ::: gfx/vr/ipc/PVRManager.ipdl (Diff revision 1) > // Reset the sensor of the display identified by aDisplayID so that the current > // sensor state is the "Zero" position. > async ResetSensor(uint32_t aDisplayID); > > sync GetSensorState(uint32_t aDisplayID) returns(VRHMDSensorState aState); > - sync GetImmediateSensorState(uint32_t aDisplayID) returns(VRHMDSensorState aState); You need to remove the corresponding entry from sync-messages.ini, and get an IPC peer to sign off on it. (Note that after bug 1345111, the build will fail if you forget to do that.)
Attachment #8845042 -
Flags: review?(ehsan) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•5 years ago
|
||
(In reply to :Ehsan Akhgari from comment #2) > Comment on attachment 8845042 [details] > Bug 1345564 - Reduce sync IPC calls used by WebVR > > https://reviewboard.mozilla.org/r/118268/#review120128 > > ::: gfx/vr/ipc/PVRManager.ipdl > (Diff revision 1) > > // Reset the sensor of the display identified by aDisplayID so that the current > > // sensor state is the "Zero" position. > > async ResetSensor(uint32_t aDisplayID); > > > > sync GetSensorState(uint32_t aDisplayID) returns(VRHMDSensorState aState); > > - sync GetImmediateSensorState(uint32_t aDisplayID) returns(VRHMDSensorState aState); > > You need to remove the corresponding entry from sync-messages.ini, and get > an IPC peer to sign off on it. (Note that after bug 1345111, the build will > fail if you forget to do that.) Thanks for spotting that! I'll also be sure to get peer review.
Assignee | ||
Updated•5 years ago
|
Attachment #8845042 -
Flags: review?(kchen)
Comment 5•5 years ago
|
||
mozreview-review |
Comment on attachment 8845042 [details] Bug 1345564 - Reduce sync IPC calls used by WebVR https://reviewboard.mozilla.org/r/118268/#review120240 LGTM
Attachment #8845042 -
Flags: review?(dmu) → review+
Comment 6•5 years ago
|
||
mozreview-review |
Comment on attachment 8845042 [details] Bug 1345564 - Reduce sync IPC calls used by WebVR https://reviewboard.mozilla.org/r/118268/#review120434
Attachment #8845042 -
Flags: review?(kchen) → review+
Comment 7•5 years ago
|
||
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 15 changes to 15 files remote: remote: remote: ************************** ERROR **************************** remote: remote: sync-messages.ini altered in changeset 70ef581fde5c without IPC peer review remote: remote: remote: Changes to sync-messages.ini in this repo require review from a IPC peer in the form of r=... remote: This is to ensure that we behave responsibly by not adding sync IPC messages that cause performance issues needlessly. We appreciate your understanding.. remote: remote: ************************************************************* remote: remote: remote: transaction abort! remote: rollback completed remote: pretxnchangegroup.d_webidl hook failed abort: push failed on remote
Comment 8•5 years ago
|
||
(In reply to Mozilla Autoland from comment #7) > remote: sync-messages.ini altered in changeset 70ef581fde5c without IPC peer > review I opened bug 1345803 to update the hook. You should be able to land again next week.
Pushed by kgilbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d8de58d33e08 Reduce sync IPC calls used by WebVR r=daoshengmu,Ehsan,kanru
Comment 10•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d8de58d33e08
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•5 years ago
|
Whiteboard: [qf:p3]
Updated•4 months ago
|
Performance: --- → P3
Whiteboard: [qf:p3]
You need to log in
before you can comment on or make changes to this bug.
Description
•