Closed Bug 1345600 Opened 3 years ago Closed 2 years ago

Investigate if we still need to create the empty script element in jsreftests

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

(Keywords: triage-deferred)

Attachments

(1 file)

Keywords: triage-deferred
Priority: -- → P3
Attached patch bug1345600.patchSplinter Review
Try builds succeed even when the empty script element is not created, so I guess this workaround can go away. 

Also replaces the document.write call to update the title as suggested in bug 1346234, comment #116.
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8926954 - Flags: review?(sphink)
Comment on attachment 8926954 [details] [diff] [review]
bug1345600.patch

Review of attachment 8926954 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, in a quick test, my first document.write was able to inject a script that was executed.
Attachment #8926954 - Flags: review?(sphink) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab5332419d2f
Remove the empty script element workaround in jstests' browser.js. r=sfink
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ab5332419d2f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.