Closed Bug 1345618 Opened 3 years ago Closed 3 years ago

add BUG_COMPONENT to modules/* files

Categories

(Core :: Graphics: Text, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file, 1 obsolete file)

many of the modules appear to be related to Graphics:Text, so I am filing the bug here, here is what I can best determine is the breakdown:
$ ./mach file-info bugzilla-component modules/**
Core :: Build Config
  modules/libbz2
Core :: General
  modules/moz.build
  modules/zlib
Core :: Graphics: Text
  modules/brotli
  modules/fdlibm
  modules/freetype2
  modules/woff2
Core :: Networking: JAR
  modules/libjar
Core :: Preferences: Backend
  modules/libpref
Firefox for Android :: General
  modules/xz-embedded
Toolkit :: Application Update
  modules/libmar
Attached patch add BUG_COMPONENT to modules/* (obsolete) — Splinter Review
:milan- many parts of Core::Graphics:Text- and anything you see in general :)

:rstrong- I have libmar for toolkit::application update, is that right, maybe Firefox::Installer?

:mcmanus- I have libjar for Core::Networking: JAR- best guess, let me know if that looks right.

I mostly looked at history of the changed files and what the predominant bugzilla component was to figure this out.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8845118 - Flags: review?(robert.strong.bugs)
Attachment #8845118 - Flags: review?(milan)
Attachment #8845118 - Flags: review?(mcmanus)
Comment on attachment 8845118 [details] [diff] [review]
add BUG_COMPONENT to modules/*

That is correct.
Attachment #8845118 - Flags: review?(robert.strong.bugs) → review+
Attachment #8845118 - Flags: review?(mcmanus) → review+
(In reply to Joel Maher ( :jmaher) from comment #0)

> Core :: Graphics: Text

>   modules/fdlibm

I don't think fdlibm is related to gfx/text; AFAICS it looks like it should be JS-engine.
(In reply to Joel Maher ( :jmaher) from comment #0)
> Core :: Graphics: Text
>   modules/brotli

Also, while brotli is used by gfx/text (via woff2), it is also used separately by netwerk. So maybe it should be left in General, like zlib?
thanks for the reviews and feedback.

I have updated the patch to go with :jfkthame's recommendations for the two directories.

we now have:
$ ./mach file-info bugzilla-component modules/**
Core :: Build Config
  modules/libbz2
Core :: General
  modules/brotli
  modules/moz.build
  modules/zlib
Core :: Graphics: Text
  modules/freetype2
  modules/woff2
Core :: JavaScript Engine
  modules/fdlibm
Core :: Networking: JAR
  modules/libjar
Core :: Preferences: Backend
  modules/libpref
Firefox for Android :: General
  modules/xz-embedded
Toolkit :: Application Update
  modules/libmar
Attachment #8845118 - Attachment is obsolete: true
Attachment #8845118 - Flags: review?(milan)
Attachment #8845133 - Flags: review?(jfkthame)
Attachment #8845133 - Flags: review?(jfkthame) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf8a395142e3
add BUG_COMPONENT to modules/* files. r=jfkthame,mcmanus,rstrong
https://hg.mozilla.org/mozilla-central/rev/cf8a395142e3
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.